You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apex.apache.org by ilooner <gi...@git.apache.org> on 2016/04/08 00:57:35 UTC
[GitHub] incubator-apex-malhar pull request: APEXMALHAR-2042 #resolve #comm...
GitHub user ilooner opened a pull request:
https://github.com/apache/incubator-apex-malhar/pull/237
APEXMALHAR-2042 #resolve #comment fixed race condition where state co…
…uld be cleared before data is transfered to a file.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ilooner/incubator-apex-malhar APEXMALHAR-2042_pull_1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-apex-malhar/pull/237.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #237
----
commit f1067df8ff8098efb35c7e2c3cebd12f7e7af93d
Author: Timothy Farkas <ti...@datatorrent.com>
Date: 2016-04-07T21:27:39Z
APEXMALHAR-2042 #resolve #comment fixed race condition where state could be cleared before data is transfered to a file.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-malhar pull request: APEXMALHAR-2042 #resolve #comm...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-apex-malhar/pull/237
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-malhar pull request: APEXMALHAR-2042 #resolve #comm...
Posted by ilooner <gi...@git.apache.org>.
Github user ilooner commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/237#discussion_r59287619
--- Diff: library/src/test/java/org/apache/apex/malhar/lib/state/managed/ManagedStateImplTest.java ---
@@ -147,9 +150,9 @@ public void testCommitted()
Slice two = ManagedStateTestUtils.getSliceFor("2");
commitHelper(one, two);
Bucket.DefaultBucket defaultBucket = (Bucket.DefaultBucket)testMeta.managedState.getBucket(0);
- Assert.assertEquals("value of one", one, defaultBucket.getCommittedData().get(one).getValue());
-
- Assert.assertNull("value of two", defaultBucket.getCommittedData().get(two));
+ Assert.assertEquals("value of one", one, defaultBucket.getCommittedData().firstEntry().getValue().get(one)
+ .getValue());
--- End diff --
This one is longer than 120.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-malhar pull request: APEXMALHAR-2042 #resolve #comm...
Posted by chandnisingh <gi...@git.apache.org>.
Github user chandnisingh commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/237#discussion_r58965377
--- Diff: library/src/test/java/org/apache/apex/malhar/lib/state/managed/ManagedStateImplTest.java ---
@@ -163,6 +168,45 @@ public void testAsyncGetFromCommitted() throws ExecutionException, InterruptedEx
Assert.assertEquals("value of one", one, valFuture.get());
}
+ /**
+ * Reproducing APEXMALHAR-2042
--- End diff --
Fix for APEXMALHAR-2042?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-malhar pull request: APEXMALHAR-2042 #resolve #comm...
Posted by chandnisingh <gi...@git.apache.org>.
Github user chandnisingh commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/237#discussion_r58965303
--- Diff: library/src/test/java/org/apache/apex/malhar/lib/state/managed/ManagedStateImplTest.java ---
@@ -147,9 +150,11 @@ public void testCommitted()
Slice two = ManagedStateTestUtils.getSliceFor("2");
commitHelper(one, two);
Bucket.DefaultBucket defaultBucket = (Bucket.DefaultBucket)testMeta.managedState.getBucket(0);
- Assert.assertEquals("value of one", one, defaultBucket.getCommittedData().get(one).getValue());
+ Assert.assertEquals("value of one",
+ one, defaultBucket.getCommittedData().firstEntry().getValue().get(one).getValue());
- Assert.assertNull("value of two", defaultBucket.getCommittedData().get(two));
+ Assert.assertNull("value of two",
+ defaultBucket.getCommittedData().firstEntry().getValue().get(two));
--- End diff --
Same as above
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-malhar pull request: APEXMALHAR-2042 #resolve #comm...
Posted by chandnisingh <gi...@git.apache.org>.
Github user chandnisingh commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/237#discussion_r58965233
--- Diff: library/src/main/java/org/apache/apex/malhar/lib/state/managed/IncrementalCheckpointManager.java ---
@@ -208,6 +209,11 @@ public void setLatestExpiredTimeBucket(long timeBucket)
latestExpiredTimeBucket.set(timeBucket);
}
+ public long getLastTransferedWindow()
--- End diff --
please document this public method
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-malhar pull request: APEXMALHAR-2042 #resolve #comm...
Posted by chandnisingh <gi...@git.apache.org>.
Github user chandnisingh commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/237#discussion_r58965285
--- Diff: library/src/test/java/org/apache/apex/malhar/lib/state/managed/ManagedStateImplTest.java ---
@@ -147,9 +150,11 @@ public void testCommitted()
Slice two = ManagedStateTestUtils.getSliceFor("2");
commitHelper(one, two);
Bucket.DefaultBucket defaultBucket = (Bucket.DefaultBucket)testMeta.managedState.getBucket(0);
- Assert.assertEquals("value of one", one, defaultBucket.getCommittedData().get(one).getValue());
+ Assert.assertEquals("value of one",
+ one, defaultBucket.getCommittedData().firstEntry().getValue().get(one).getValue());
--- End diff --
this is less 120 lines. please don't break it into 2 lines
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---