[GitHub] [incubator-opendal] xxchan commented on a diff in pull request #1706: feat(oli): add config file to oli

["xxchan (via GitHub)" <gi...@apache.org>]

xxchan commented on code in PR #1706:
URL: https://github.com/apache/incubator-opendal/pull/1706#discussion_r1142276535


##########
binaries/oli/src/bin/oli.rs:
##########
@@ -28,6 +28,23 @@ use std::path::PathBuf;
 
 use anyhow::anyhow;
 use anyhow::Result;
+use clap::{value_parser, Arg, Command};
+use home::home_dir;
+
+fn new_cmd(name: &'static str) -> Result<Command> {
+    let home = home_dir().ok_or_else(|| anyhow!("unknown home dir"))?;
+    let default_config_path = home.join(".oli/config.toml").as_os_str().to_owned();

Review Comment:
   > It's more common to use `~/.config/oli/config.toml`
   
   Any references? 👀 There's e.g., `~/.config/nextest.toml`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org