You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/04/14 12:50:39 UTC
[GitHub] [superset] cemremengu opened a new pull request, #19718: docs(alerts): update chromedriver
cemremengu opened a new pull request, #19718:
URL: https://github.com/apache/superset/pull/19718
### SUMMARY
Use `LATEST` tag for chrome driver to prevent errors like `SessionNotCreatedError: session not created: This version of ChromeDriver only supports Chrome version 88 Current browser version is..`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #19718: docs(alerts): update chromedriver
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #19718:
URL: https://github.com/apache/superset/pull/19718#issuecomment-1406920443
@cemremengu I'm sorry to admit I've lost track of the intricacies, but there were a lot of discussions/changes around chrome driver versions lately. Is this PR still relevant?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #19718: docs(alerts): update chromedriver
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #19718:
URL: https://github.com/apache/superset/pull/19718#issuecomment-1410732027
OK. I see that the PR you link to (which is causing the conflict on this one) was attempting to do a similar thing, but @villebro had feelings that sticking to pinned versions was a good idea. I'm not familiar with the intricacies here (though I'd _like_ to be), so in pinging him here, maybe we can play out the conversation a bit more.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] docs(alerts): update chromedriver [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #19718:
URL: https://github.com/apache/superset/pull/19718#issuecomment-1930680692
Curious if anyone here is still seeing a need to follow through on this... I'm not sure which is riskier — _not_ bumping, or bumping to an unbound version. This PR does need a rebase though, if it's going to become mergeable. That should also retrigger CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] cemremengu commented on pull request #19718: docs(alerts): update chromedriver
Posted by "cemremengu (via GitHub)" <gi...@apache.org>.
cemremengu commented on PR #19718:
URL: https://github.com/apache/superset/pull/19718#issuecomment-1407447406
@rusackas I see #22517 but that PR still pins the version. With the next chrome driver release, it will probably break again with same error.
This PR in contrast updates the download link to not use a specific version in an attempt to fix the issue for good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org