You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2015/10/25 20:19:46 UTC
[Bug 58534] New: Repeated Conditional Test
https://bz.apache.org/bugzilla/show_bug.cgi?id=58534
Bug ID: 58534
Summary: Repeated Conditional Test
Product: Tomcat 8
Version: trunk
Hardware: Macintosh
OS: Mac OS X 10.1
Status: NEW
Severity: trivial
Priority: P2
Component: WebSocket
Assignee: dev@tomcat.apache.org
Reporter: anthony@whitford.com
In org.apache.tomcat.websocket.pojo.PojoMethodMapping, there are cases like
this:
if (currentClazz == clazzPojo ||
(currentClazz != clazzPojo && !isMethodOverride(open, method))) {
The clause 'currentClazz != clazzPojo' is redundant since we know 'currentClazz
== clazzPojo' is false.
This is repeated several times.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 58534] Repeated Conditional Test
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58534
Violeta Georgieva <vi...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|NEW |RESOLVED
--- Comment #3 from Violeta Georgieva <vi...@apache.org> ---
Hi,
Thanks for the report and the patch.
The fix is available in trunk, 8.0.x (for 8.0.29 onwards) and 7.0.x (for 7.0.66
onwards)
Regards,
Violeta
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 58534] Repeated Conditional Test
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58534
--- Comment #2 from Anthony Whitford <an...@whitford.com> ---
Created attachment 33209
--> https://bz.apache.org/bugzilla/attachment.cgi?id=33209&action=edit
Patch for similar problem for AprEndpoint
I discovered the same problem with org.apache.tomcat.util.net.AprEndpoint, so
please see the second patch too.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 58534] Repeated Conditional Test
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58534
--- Comment #1 from Anthony Whitford <an...@whitford.com> ---
Created attachment 33208
--> https://bz.apache.org/bugzilla/attachment.cgi?id=33208&action=edit
Patch to remove repeated conditional tests
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org