[GitHub] [servicecomb-service-center] little-cui commented on a change in pull request #1216: [feat] normal access traffic needs to be synchronized

[GitBox <gi...@apache.org>]

little-cui commented on a change in pull request #1216:
URL: https://github.com/apache/servicecomb-service-center/pull/1216#discussion_r782732218



##########
File path: datasource/etcd/account.go
##########
@@ -83,12 +83,14 @@ func (ds *RbacDAO) CreateAccount(ctx context.Context, a *crbac.Account) error {
 		log.Error("", err)
 		return err
 	}
-	syncOpts, err := esync.GenCreateOpts(ctx, datasource.ResourceAccount, a)
-	if err != nil {
-		log.Error("fail to create sync opts", err)
-		return err
+	if util.EnableSync(ctx) {
+		syncOpts, err := esync.GenCreateOpts(ctx, datasource.ResourceAccount, a)

Review comment:
       在GenCreateOpts里层判断，减少散弹式修改




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org