You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2021/03/26 07:08:11 UTC
svn commit: r1888078 - in
/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox: cos/COSArray.java
pdmodel/PDPage.java
Author: tilman
Date: Fri Mar 26 07:08:11 2021
New Revision: 1888078
URL: http://svn.apache.org/viewvc?rev=1888078&view=rev
Log:
PDFBOX-4892: simplify code, as suggested by valerybokov
Modified:
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/cos/COSArray.java
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/PDPage.java
Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/cos/COSArray.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/cos/COSArray.java?rev=1888078&r1=1888077&r2=1888078&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/cos/COSArray.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/cos/COSArray.java Fri Mar 26 07:08:11 2021
@@ -587,9 +587,7 @@ public class COSArray extends COSBase im
*/
public List<? extends COSBase> toList()
{
- List<COSBase> retList = new ArrayList<>(size());
- objects.forEach(retList::add);
- return retList;
+ return new ArrayList<>(objects);
}
/**
Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/PDPage.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/PDPage.java?rev=1888078&r1=1888077&r2=1888078&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/PDPage.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/PDPage.java Fri Mar 26 07:08:11 2021
@@ -522,9 +522,7 @@ public class PDPage implements COSObject
*/
public void setContents(List<PDStream> contents)
{
- COSArray array = new COSArray();
- contents.forEach(array::add);
- page.setItem(COSName.CONTENTS, array);
+ page.setItem(COSName.CONTENTS, new COSArray(contents));
}
/**
@@ -760,9 +758,7 @@ public class PDPage implements COSObject
page.removeItem(COSName.VP);
return;
}
- COSArray array = new COSArray();
- viewports.forEach(array::add);
- page.setItem(COSName.VP, array);
+ page.setItem(COSName.VP, new COSArray(viewports));
}
/**