You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/02/27 02:03:07 UTC
[GitHub] sunjincheng121 commented on a change in pull request #7837: [FLINK-11091][table] Clear the use of deprecated `process(ProcessFunc…
sunjincheng121 commented on a change in pull request #7837: [FLINK-11091][table] Clear the use of deprecated `process(ProcessFunc…
URL: https://github.com/apache/flink/pull/7837#discussion_r260566766
##########
File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamGroupAggregate.scala
##########
@@ -131,32 +134,42 @@ class DataStreamGroupAggregate(
s"select: ($aggString)"
val nonKeyedAggOpName = s"select: ($aggString)"
- val processFunction = AggregateUtil.createGroupAggregateFunction(
- generator,
- namedAggregates,
- inputSchema.relDataType,
- inputSchema.fieldTypeInfos,
- groupings,
- queryConfig,
- tableEnv.getConfig,
- DataStreamRetractionRules.isAccRetract(this),
- DataStreamRetractionRules.isAccRetract(getInput))
-
val result: DataStream[CRow] =
- // grouped / keyed aggregation
+ // grouped / keyed aggregation
if (groupings.nonEmpty) {
+ val keyedProcessFunction = AggregateUtil.createGroupAggregateFunction[Row](
Review comment:
I'm not sure if abstracting an internal method that contains only one method call is the best, but the code looks really clean. +1 for your proposal.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services