You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/01/01 00:31:06 UTC
[GitHub] [incubator-doris] zuochunwei opened a new pull request #7567: [refactor](common) eliminate class COW dependence on boost
zuochunwei opened a new pull request #7567:
URL: https://github.com/apache/incubator-doris/pull/7567
## Proposed changes
1. replace boost library relative classes & functions with hand writing implement
2. avoid casting for get_ptr()
3. COW and its derived class COWHelper both defined non-virtual member derived() , it is bad practice and should avoid doing like this
4. i try to use deriving from std::unique_ptr to implement mutable_ptr, and deriving from std::shared_ptr to implement immutable_ptr，but it's very difficult to complete because will result in massive modifications
Close related #issue (replace it with issue number if it exists).
Describe the overview of changes, and introduce why we need it.
## Types of changes
What types of changes does your code introduce to Doris?
_Put an `x` in the boxes that apply_
- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation Update (if none of the other choices apply)
- [ ] Code refactor (Modify the code structure, format the code, etc...)
- [ ] Optimization. Including functional usability improvements and performance improvements.
- [ ] Dependency. Such as changes related to third-party components.
- [ ] Other.
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [ ] I have created an issue on (Fix #ISSUE) and described the bug/feature there in detail
- [ ] Compiling and unit tests pass locally with my changes
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] If these changes need document changes, I have updated the document
- [ ] Any dependent changes have been merged
## Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] HappenLee merged pull request #7567: [vectorized][refactor](common) eliminate class COW dependence on boost
Posted by GitBox <gi...@apache.org>.
HappenLee merged pull request #7567:
URL: https://github.com/apache/incubator-doris/pull/7567
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #7567: [vectorized][refactor](common) eliminate class COW dependence on boost
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7567:
URL: https://github.com/apache/incubator-doris/pull/7567#issuecomment-1005467110
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] HappenLee commented on a change in pull request #7567: [vectorized][refactor](common) eliminate class COW dependence on boost
Posted by GitBox <gi...@apache.org>.
HappenLee commented on a change in pull request #7567:
URL: https://github.com/apache/incubator-doris/pull/7567#discussion_r778943297
##########
File path: be/src/vec/common/cow.h
##########
@@ -92,36 +93,158 @@
* to use std::unique_ptr for it somehow.
*/
template <typename Derived>
-class COW : public boost::intrusive_ref_counter<Derived> {
-private:
+class COW {
+ std::atomic_uint ref_counter;
+
+protected:
+ COW() : ref_counter(0) {}
+
+ COW(COW const&) : ref_counter(0) {}
+
+ COW& operator=(COW const&) {
+ return *this;
+ }
+
+ unsigned int use_count() const {
+ return ref_counter.load();
+ }
+
+ void add_ref() {
+ ++ref_counter;
+ }
+
+ void release_ref() {
Review comment:
Rethink here may cause mem leak? How boost::intrusive_ref_counter prevent the problem
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org