You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "Viet Hung Nguyen (JIRA)" <ji...@apache.org> on 2007/10/31 21:13:51 UTC
[jira] Created: (GERONIMO-3573) monitoring plugin: collecting
agent's EJB should not be spawning and monitoring a thread
monitoring plugin: collecting agent's EJB should not be spawning and monitoring a thread
----------------------------------------------------------------------------------------
Key: GERONIMO-3573
URL: https://issues.apache.org/jira/browse/GERONIMO-3573
Project: Geronimo
Issue Type: Improvement
Security Level: public (Regular issues)
Environment: windows
Reporter: Viet Hung Nguyen
The collecting agent is spawning and monitoring a thread. It does this in order to periodically capture snapshots of the server's status. However, Anita pointed out that it is a violation of the EJB spec. And I have confirmed this. An alternative is to use EJB's TimerService.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMO-3573) monitoring plugin: collecting
agent's EJB should not be spawning and monitoring a thread
Posted by "Viet Hung Nguyen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-3573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Viet Hung Nguyen updated GERONIMO-3573:
---------------------------------------
Component/s: monitoring
Affects Version/s: 2.1
> monitoring plugin: collecting agent's EJB should not be spawning and monitoring a thread
> ----------------------------------------------------------------------------------------
>
> Key: GERONIMO-3573
> URL: https://issues.apache.org/jira/browse/GERONIMO-3573
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: monitoring
> Affects Versions: 2.1
> Environment: windows
> Reporter: Viet Hung Nguyen
> Attachments: geronimo-3573.patch
>
>
> The collecting agent is spawning and monitoring a thread. It does this in order to periodically capture snapshots of the server's status. However, Anita pointed out that it is a violation of the EJB spec. And I have confirmed this. An alternative is to use EJB's TimerService.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMO-3573) monitoring plugin: collecting
agent's EJB should not be spawning and monitoring a thread
Posted by "Viet Hung Nguyen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-3573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Viet Hung Nguyen updated GERONIMO-3573:
---------------------------------------
Attachment: geronimo-3573.patch
This patch gets rid of any threads created and managed by the Master EJB and replaces it with a TimerService which is injected via annotations. Jarek recently put a patch in for OpenEJB that was committed to fix TimerService injection, but they have not published it to their repo yet.
So in order to run this, I had to build OpenEJB locally, then build Geronimo trunk.
mrc-server/mrc-ejb/src/main/java/org/apache/geronimo/monitor/snapshots/SnapshotXMLBuilder.java
and
mrc-server/mrc-ejb/src/main/java/org/apache/geronimo/monitor/snapshots/SnapshotThread.java
are not longer needed. So, if this patch merits a commit, I hope the committer will also remove these files from the repo too.
> monitoring plugin: collecting agent's EJB should not be spawning and monitoring a thread
> ----------------------------------------------------------------------------------------
>
> Key: GERONIMO-3573
> URL: https://issues.apache.org/jira/browse/GERONIMO-3573
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Environment: windows
> Reporter: Viet Hung Nguyen
> Attachments: geronimo-3573.patch
>
>
> The collecting agent is spawning and monitoring a thread. It does this in order to periodically capture snapshots of the server's status. However, Anita pointed out that it is a violation of the EJB spec. And I have confirmed this. An alternative is to use EJB's TimerService.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-3573) monitoring plugin: collecting
agent's EJB should not be spawning and monitoring a thread
Posted by "Jarek Gawor (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-3573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12539684 ]
Jarek Gawor commented on GERONIMO-3573:
---------------------------------------
Viet,
A few comments:
1) SnapshotProcessor does not need to extend Thread
2) "org.openejb.client.RemoteInitialContextFactory" should be "org.apache.openejb.client.RemoteInitialContextFactory"
3) Start using Commons Logging API instead of outputting stuff to System.out or doing e.printStackTrace()
> monitoring plugin: collecting agent's EJB should not be spawning and monitoring a thread
> ----------------------------------------------------------------------------------------
>
> Key: GERONIMO-3573
> URL: https://issues.apache.org/jira/browse/GERONIMO-3573
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: monitoring
> Affects Versions: 2.1
> Environment: windows
> Reporter: Viet Hung Nguyen
> Attachments: geronimo-3573.patch
>
>
> The collecting agent is spawning and monitoring a thread. It does this in order to periodically capture snapshots of the server's status. However, Anita pointed out that it is a violation of the EJB spec. And I have confirmed this. An alternative is to use EJB's TimerService.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.