You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/01/01 06:41:08 UTC

[GitHub] [apisix-java-plugin-runner] tzssangglass opened a new pull request #108: docs: adding function definitions for the PluginFilter interface

tzssangglass opened a new pull request #108:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/108


   Signed-off-by: tzssangglass <tz...@gmail.com>
   
   Please answer these questions before submitting a pull request
   
   - Why submit this pull request?
   - [ ] Bugfix
   - [ ] New feature provided
   - [ ] Improve performance
   
   - Related issues
   
   ___
   ### Bugfix
   - Description
   
   - How to fix?
   
   ___
   ### New feature or improvement
   - Describe the details and related test reports.
   
   - Source branch
   
   - Related commits and pull requests
   
   - Target branch
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-java-plugin-runner] tzssangglass commented on a change in pull request #108: docs: adding function definitions for the PluginFilter interface

Posted by GitBox <gi...@apache.org>.
tzssangglass commented on a change in pull request #108:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/108#discussion_r777282194



##########
File path: README.md
##########
@@ -20,7 +20,7 @@ security, traffic control, serverless, analytics & monitoring, transformations,
 It also provides highly extensible API, allowing common phases to be mounted,
 and users can use these api to develop their own plugins.
 
-APISIX supports writing plugins in multiple languages in version [2.7.0](https://github.com/apache/apisix/blob/master/CHANGELOG.md#270),
+APISIX supports writing plugins in multiple languages in version [2.10.2](https://github.com/apache/apisix/blob/master/CHANGELOG.md#2102),

Review comment:
       now I use version martix, since apisix-java-plugin-runner can only run one version, I want to tell the user directly the version relationship between apisix-java-plugin-runner and APISIX。




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-java-plugin-runner] spacewander commented on a change in pull request #108: docs: adding function definitions for the PluginFilter interface

Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #108:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/108#discussion_r777224828



##########
File path: README.md
##########
@@ -20,7 +20,7 @@ security, traffic control, serverless, analytics & monitoring, transformations,
 It also provides highly extensible API, allowing common phases to be mounted,
 and users can use these api to develop their own plugins.
 
-APISIX supports writing plugins in multiple languages in version [2.7.0](https://github.com/apache/apisix/blob/master/CHANGELOG.md#270),
+APISIX supports writing plugins in multiple languages in version [2.10.2](https://github.com/apache/apisix/blob/master/CHANGELOG.md#2102),

Review comment:
       Would be better if we doc the version requirement in each API instead of requiring the latest?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-java-plugin-runner] tzssangglass merged pull request #108: docs: adding function definitions for the PluginFilter interface

Posted by GitBox <gi...@apache.org>.
tzssangglass merged pull request #108:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/108


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org