[GitHub] HyukjinKwon commented on a change in pull request #23482: [SPARK-26554][BUILD][FOLLOWUP] Use GitHub instead of GitBox to check HEADER

[GitBox <gi...@apache.org>]

HyukjinKwon commented on a change in pull request #23482: [SPARK-26554][BUILD][FOLLOWUP] Use GitHub instead of GitBox to check HEADER
URL: https://github.com/apache/spark/pull/23482#discussion_r245580655
 
 

 ##########
 File path: dev/create-release/release-util.sh
 ##########
 @@ -21,6 +21,7 @@ DRY_RUN=${DRY_RUN:-0}
 GPG="gpg --no-tty --batch"
 ASF_REPO="https://gitbox.apache.org/repos/asf/spark.git"
 ASF_REPO_WEBUI="https://gitbox.apache.org/repos/asf?p=spark.git"
+ASF_GITHUB_REPO="https://github.com/apache/spark"
 
 Review comment:
   Hm, I wonder if I completely agree with it. Mixing gitbox and github could look a bit confusing. The previous `! curl -s --fail "$ASF_REPO_WEBUI;a=commit;h=$1" | grep '404 Not Found' > /dev/null` is good enough I guess. I'm okay but let's don't do this if it's not only me feeling in this way.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org