You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2019/10/14 16:45:24 UTC
[kudu-CR] net util: tag DNS resolution as a blocking operation
Hello Alexey Serbin, Andrew Wong,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/14424
to review the following change.
Change subject: net_util: tag DNS resolution as a blocking operation
......................................................................
net_util: tag DNS resolution as a blocking operation
ThreadRestrictions tags are basically only used to prevent reactor threads
from doing IO or invoking blocking operations. For some reason we didn't
annotate DNS resolution as blocking. After doing so, I had to make a few
exceptions in existing code. They're not great, but at least they're not in
tserver reactors.
Change-Id: I90e280855bc8e6797f887da26dfa67cfaf945dcf
---
M src/kudu/client/client-internal.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/util/net/net_util.cc
3 files changed, 12 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/24/14424/1
--
To view, visit http://gerrit.cloudera.org:8080/14424
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I90e280855bc8e6797f887da26dfa67cfaf945dcf
Gerrit-Change-Number: 14424
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
[kudu-CR] net util: tag DNS resolution as a blocking operation
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14424 )
Change subject: net_util: tag DNS resolution as a blocking operation
......................................................................
net_util: tag DNS resolution as a blocking operation
ThreadRestrictions tags are basically only used to prevent reactor threads
from doing IO or invoking blocking operations. For some reason we didn't
annotate DNS resolution as blocking. After doing so, I had to make a few
exceptions in existing code. They're not great, but at least they're not in
tserver reactors.
Change-Id: I90e280855bc8e6797f887da26dfa67cfaf945dcf
Reviewed-on: http://gerrit.cloudera.org:8080/14424
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/client/client-internal.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/master/catalog_manager.h
M src/kudu/util/net/net_util.cc
4 files changed, 13 insertions(+), 2 deletions(-)
Approvals:
Alexey Serbin: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/14424
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I90e280855bc8e6797f887da26dfa67cfaf945dcf
Gerrit-Change-Number: 14424
Gerrit-PatchSet: 3
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] net util: tag DNS resolution as a blocking operation
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14424
to look at the new patch set (#2).
Change subject: net_util: tag DNS resolution as a blocking operation
......................................................................
net_util: tag DNS resolution as a blocking operation
ThreadRestrictions tags are basically only used to prevent reactor threads
from doing IO or invoking blocking operations. For some reason we didn't
annotate DNS resolution as blocking. After doing so, I had to make a few
exceptions in existing code. They're not great, but at least they're not in
tserver reactors.
Change-Id: I90e280855bc8e6797f887da26dfa67cfaf945dcf
---
M src/kudu/client/client-internal.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/master/catalog_manager.h
M src/kudu/util/net/net_util.cc
4 files changed, 13 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/24/14424/2
--
To view, visit http://gerrit.cloudera.org:8080/14424
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I90e280855bc8e6797f887da26dfa67cfaf945dcf
Gerrit-Change-Number: 14424
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] net util: tag DNS resolution as a blocking operation
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14424 )
Change subject: net_util: tag DNS resolution as a blocking operation
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14424
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I90e280855bc8e6797f887da26dfa67cfaf945dcf
Gerrit-Change-Number: 14424
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 14 Oct 2019 17:27:50 +0000
Gerrit-HasComments: No