You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Akila Wajirasena <ak...@gmail.com> on 2014/02/04 17:52:29 UTC
Status of Drill Functions
Hi,
I'm Akila, a software engineer from Sri Lanka. I would like to contribute
to this project.
I went through the materials provided in the site and thought of starting
to implement some
drill functions. I have some questions regarding that;
I found the document on functions needed to be implemented [1]. I would
like to know if any of those
functions already implemented?
Then I found ComparisonFunctions class mentioned in "Contributing" wiki
page
is commented out. Is it no longer in use?
[1]
https://docs.google.com/spreadsheet/ccc?key=0Aoz_rQ71aIZ5dC0tN2FhNzY1c0JzV1RpOTZQM0hMdEE&usp=sharing#gid=0
--
Regards
Akila Wajirasena
Re: Status of Drill Functions
Posted by Mehant Baid <ba...@gmail.com>.
I think so, I am going refresh the patch so it applies cleanly to the
master branch and submit it.
Thanks
Mehant
On 2/7/14, 7:30 PM, Akila Wajirasena wrote:
> Dear Steven and Mehant,
>
> Are we going to merge
> DRILL-320<https://issues.apache.org/jira/browse/DRILL-320> to
> master any any time soon?
>
> Thanks,
> Akila
>
Re: Status of Drill Functions
Posted by Akila Wajirasena <ak...@gmail.com>.
Dear Steven and Mehant,
Are we going to merge
DRILL-320<https://issues.apache.org/jira/browse/DRILL-320> to
master any any time soon?
Thanks,
Akila
On Wed, Feb 5, 2014 at 11:03 PM, Akila Wajirasena <
akila.wajirasena@gmail.com> wrote:
> Thanks Rajika for the link.
>
> Mehant, Thanks for the information. I tried your patch, there was a
> conflict when applying the patch to current master
> in MathFunctions.java. I did a three way merge in git but still had to
> fix the conflicts manually. I will try to add some
> more functions on top of your code.
>
> I think this patch (https://issues.apache.org/jira/browse/DRILL-199) also
> should have used freemarker.
> I can create a template for this as a start.
>
> Thanks,
>
> Akila
>
>
>
> On Wed, Feb 5, 2014 at 9:39 AM, Rajika Kumarasiri <
> rajika.kumarasiri@gmail.com> wrote:
>
>> Below entry shows how to implement a function. Hope it helps.
>>
>>
>> http://www.confusedcoders.com/bigdata/apache-drill/how-to-contribute-to-apache-drill-implementing-drill-math-functions
>>
>> Rajika
>>
>>
>> On Tue, Feb 4, 2014 at 11:52 AM, Akila Wajirasena <
>> akila.wajirasena@gmail.com> wrote:
>>
>> > Hi,
>> >
>> > I'm Akila, a software engineer from Sri Lanka. I would like to
>> contribute
>> > to this project.
>> > I went through the materials provided in the site and thought of
>> starting
>> > to implement some
>> > drill functions. I have some questions regarding that;
>> >
>> > I found the document on functions needed to be implemented [1]. I would
>> > like to know if any of those
>> > functions already implemented?
>> >
>> > Then I found ComparisonFunctions class mentioned in "Contributing" wiki
>> > page
>> > is commented out. Is it no longer in use?
>> >
>> >
>> > [1]
>> >
>> >
>> https://docs.google.com/spreadsheet/ccc?key=0Aoz_rQ71aIZ5dC0tN2FhNzY1c0JzV1RpOTZQM0hMdEE&usp=sharing#gid=0
>> >
>> > --
>> > Regards
>> > Akila Wajirasena
>> >
>>
>
>
>
>
>
>
Re: Status of Drill Functions
Posted by Akila Wajirasena <ak...@gmail.com>.
Thanks Rajika for the link.
Mehant, Thanks for the information. I tried your patch, there was a
conflict when applying the patch to current master
in MathFunctions.java. I did a three way merge in git but still had to fix
the conflicts manually. I will try to add some
more functions on top of your code.
I think this patch (https://issues.apache.org/jira/browse/DRILL-199) also
should have used freemarker.
I can create a template for this as a start.
Thanks,
Akila
On Wed, Feb 5, 2014 at 9:39 AM, Rajika Kumarasiri <
rajika.kumarasiri@gmail.com> wrote:
> Below entry shows how to implement a function. Hope it helps.
>
>
> http://www.confusedcoders.com/bigdata/apache-drill/how-to-contribute-to-apache-drill-implementing-drill-math-functions
>
> Rajika
>
>
> On Tue, Feb 4, 2014 at 11:52 AM, Akila Wajirasena <
> akila.wajirasena@gmail.com> wrote:
>
> > Hi,
> >
> > I'm Akila, a software engineer from Sri Lanka. I would like to contribute
> > to this project.
> > I went through the materials provided in the site and thought of starting
> > to implement some
> > drill functions. I have some questions regarding that;
> >
> > I found the document on functions needed to be implemented [1]. I would
> > like to know if any of those
> > functions already implemented?
> >
> > Then I found ComparisonFunctions class mentioned in "Contributing" wiki
> > page
> > is commented out. Is it no longer in use?
> >
> >
> > [1]
> >
> >
> https://docs.google.com/spreadsheet/ccc?key=0Aoz_rQ71aIZ5dC0tN2FhNzY1c0JzV1RpOTZQM0hMdEE&usp=sharing#gid=0
> >
> > --
> > Regards
> > Akila Wajirasena
> >
>
Re: Status of Drill Functions
Posted by Rajika Kumarasiri <ra...@gmail.com>.
Below entry shows how to implement a function. Hope it helps.
http://www.confusedcoders.com/bigdata/apache-drill/how-to-contribute-to-apache-drill-implementing-drill-math-functions
Rajika
On Tue, Feb 4, 2014 at 11:52 AM, Akila Wajirasena <
akila.wajirasena@gmail.com> wrote:
> Hi,
>
> I'm Akila, a software engineer from Sri Lanka. I would like to contribute
> to this project.
> I went through the materials provided in the site and thought of starting
> to implement some
> drill functions. I have some questions regarding that;
>
> I found the document on functions needed to be implemented [1]. I would
> like to know if any of those
> functions already implemented?
>
> Then I found ComparisonFunctions class mentioned in "Contributing" wiki
> page
> is commented out. Is it no longer in use?
>
>
> [1]
>
> https://docs.google.com/spreadsheet/ccc?key=0Aoz_rQ71aIZ5dC0tN2FhNzY1c0JzV1RpOTZQM0hMdEE&usp=sharing#gid=0
>
> --
> Regards
> Akila Wajirasena
>
Re: Status of Drill Functions
Posted by Mehant Baid <ba...@gmail.com>.
The math functions found in
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/MathFunctions.java
is not generated using freemarker, they were written by hand.
However look at the patch in jira DRILL-320
<https://issues.apache.org/jira/browse/DRILL-320> which will replace the
existing MathFunctions class and uses freemarker to generate code for
basic math functions (+,-,*,/)
Thanks
Mehant
On 2/4/14, 10:24 AM, Akila Wajirasena wrote:
> Hi,
>
> Is this the same for the math functions found in
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/MathFunctions.java
> ?
>
>
>
>
> On Tue, Feb 4, 2014 at 11:20 PM, Steven Phillips <sp...@maprtech.com>wrote:
>
>> Drill uses compile time code generation for implementing functions, rather
>> than needing to implement by hand.
>>
>> Please take a look at exec/java-exec/src/main/codegen/ to see how it is
>> done, and model any new functions on that.
>>
>> For reference, here is info about freemarker:
>>
>> http://freemarker.org/
>>
>>
>> On Tue, Feb 4, 2014 at 8:52 AM, Akila Wajirasena <
>> akila.wajirasena@gmail.com
>>> wrote:
>>> Hi,
>>>
>>> I'm Akila, a software engineer from Sri Lanka. I would like to contribute
>>> to this project.
>>> I went through the materials provided in the site and thought of starting
>>> to implement some
>>> drill functions. I have some questions regarding that;
>>>
>>> I found the document on functions needed to be implemented [1]. I would
>>> like to know if any of those
>>> functions already implemented?
>>>
>>> Then I found ComparisonFunctions class mentioned in "Contributing" wiki
>>> page
>>> is commented out. Is it no longer in use?
>>>
>>>
>>> [1]
>>>
>>>
>> https://docs.google.com/spreadsheet/ccc?key=0Aoz_rQ71aIZ5dC0tN2FhNzY1c0JzV1RpOTZQM0hMdEE&usp=sharing#gid=0
>>> --
>>> Regards
>>> Akila Wajirasena
>>>
>
>
Re: Status of Drill Functions
Posted by Akila Wajirasena <ak...@gmail.com>.
Hi,
Is this the same for the math functions found in
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/MathFunctions.java
?
On Tue, Feb 4, 2014 at 11:20 PM, Steven Phillips <sp...@maprtech.com>wrote:
> Drill uses compile time code generation for implementing functions, rather
> than needing to implement by hand.
>
> Please take a look at exec/java-exec/src/main/codegen/ to see how it is
> done, and model any new functions on that.
>
> For reference, here is info about freemarker:
>
> http://freemarker.org/
>
>
> On Tue, Feb 4, 2014 at 8:52 AM, Akila Wajirasena <
> akila.wajirasena@gmail.com
> > wrote:
>
> > Hi,
> >
> > I'm Akila, a software engineer from Sri Lanka. I would like to contribute
> > to this project.
> > I went through the materials provided in the site and thought of starting
> > to implement some
> > drill functions. I have some questions regarding that;
> >
> > I found the document on functions needed to be implemented [1]. I would
> > like to know if any of those
> > functions already implemented?
> >
> > Then I found ComparisonFunctions class mentioned in "Contributing" wiki
> > page
> > is commented out. Is it no longer in use?
> >
> >
> > [1]
> >
> >
> https://docs.google.com/spreadsheet/ccc?key=0Aoz_rQ71aIZ5dC0tN2FhNzY1c0JzV1RpOTZQM0hMdEE&usp=sharing#gid=0
> >
> > --
> > Regards
> > Akila Wajirasena
> >
>
--
Regards
Akila Wajirasena
Re: Status of Drill Functions
Posted by Steven Phillips <sp...@maprtech.com>.
Drill uses compile time code generation for implementing functions, rather
than needing to implement by hand.
Please take a look at exec/java-exec/src/main/codegen/ to see how it is
done, and model any new functions on that.
For reference, here is info about freemarker:
http://freemarker.org/
On Tue, Feb 4, 2014 at 8:52 AM, Akila Wajirasena <akila.wajirasena@gmail.com
> wrote:
> Hi,
>
> I'm Akila, a software engineer from Sri Lanka. I would like to contribute
> to this project.
> I went through the materials provided in the site and thought of starting
> to implement some
> drill functions. I have some questions regarding that;
>
> I found the document on functions needed to be implemented [1]. I would
> like to know if any of those
> functions already implemented?
>
> Then I found ComparisonFunctions class mentioned in "Contributing" wiki
> page
> is commented out. Is it no longer in use?
>
>
> [1]
>
> https://docs.google.com/spreadsheet/ccc?key=0Aoz_rQ71aIZ5dC0tN2FhNzY1c0JzV1RpOTZQM0hMdEE&usp=sharing#gid=0
>
> --
> Regards
> Akila Wajirasena
>