[GitHub] [iceberg] singhpk234 commented on a diff in pull request #6655: Spark: Handle ResolvingFileIO while determining LocalityPreference

["singhpk234 (via GitHub)" <gi...@apache.org>]

singhpk234 commented on code in PR #6655:
URL: https://github.com/apache/iceberg/pull/6655#discussion_r1086085951


##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/SparkReadConf.java:
##########
@@ -67,11 +69,15 @@ public boolean caseSensitive() {
   }
 
   public boolean localityEnabled() {
-    if (table.io() instanceof HadoopFileIO) {
-      HadoopInputFile file = (HadoopInputFile) table.io().newInputFile(table.location());
-      String scheme = file.getFileSystem().getScheme();
-      boolean defaultValue = LOCALITY_WHITELIST_FS.contains(scheme);
-      return PropertyUtil.propertyAsBoolean(readOptions, SparkReadOptions.LOCALITY, defaultValue);
+    if (table.io() instanceof HadoopFileIO || table.io() instanceof ResolvingFileIO) {

Review Comment:
   > I am wondering if we should make ResolvingFileIO.implFromLocation a public method so we can know the FileIO used for the location without the need to open input file.
   
   +1 on this, will certainly help.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org