[jira] [Commented] (MESOS-3909) isolator module headers depend on picojson headers

["James Peach (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-3909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15047499#comment-15047499 ] 

James Peach commented on MESOS-3909:
------------------------------------

Looking at {{stout/json.hpp}}, the dependency on {{picojson}} could easily be eliminated by moving some of the inline functions in the header to a {{.cpp}} file.

> isolator module headers depend on picojson headers
> --------------------------------------------------
>
>                 Key: MESOS-3909
>                 URL: https://issues.apache.org/jira/browse/MESOS-3909
>             Project: Mesos
>          Issue Type: Bug
>          Components: c++ api, modules
>            Reporter: James Peach
>            Assignee: James Peach
>
> When trying to build an isolator module, stout headers end up depending on {{picojson.hpp}} which is not installed.
> {code}
> In file included from /opt/mesos/include/mesos/module/isolator.hpp:25:
> In file included from /opt/mesos/include/mesos/slave/isolator.hpp:30:
> In file included from /opt/mesos/include/process/dispatch.hpp:22:
> In file included from /opt/mesos/include/process/process.hpp:26:
> In file included from /opt/mesos/include/process/event.hpp:21:
> In file included from /opt/mesos/include/process/http.hpp:39:
> /opt/mesos/include/stout/json.hpp:23:10: fatal error: 'picojson.h' file not found
> #include <picojson.h>
>          ^
> 8 warnings and 1 error generated.
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)