[GitHub] [tvm-vta] tmoreau89 commented on pull request #27: Chisel Pipelined ALU

[GitBox <gi...@apache.org>]

tmoreau89 commented on pull request #27:
URL: https://github.com/apache/tvm-vta/pull/27#issuecomment-856363593


   > @tmoreau89, @vegaluisjose: I see that "tests/scripts/task_python_vta_tsim.sh" is being skipped in the pr-merge CI. Do you know why this is happening?
   > 
   > The 2 pytest commands in this test run successfully for me in ~12 min or so. I was considering extending the tsim test with Chisel unit tests ("sbt test"), but perhaps it is being skipped since the runtime is already too high?
   
   Thank you for the extensive PR @adavare and team. On the testing, I think it would be good to run some more extensive unit tests in this repo (TVM submodule) but we'll want to limit the overall runtime of the Chisel tests in the mainline repo (CI testing is already getting very long).
   
   I'm not too worried about making the CI testing time long on the tvm-vta repo given that PRs don't get submitted too often. Therefore I'm in favor of running longer, more extensive tests.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org