You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/02/09 20:49:11 UTC
[GitHub] [airflow] potiuk opened a new pull request #7390: [AIRFLOW-6764]
Fixed environment installation for Linux
potiuk opened a new pull request #7390: [AIRFLOW-6764] Fixed environment installation for Linux
URL: https://github.com/apache/airflow/pull/7390
---
Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
<sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #7390: [AIRFLOW-6764] Fixed
environment installation for Linux
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #7390: [AIRFLOW-6764] Fixed environment installation for Linux
URL: https://github.com/apache/airflow/pull/7390#issuecomment-583891735
I switched to Linux environment for my home setup and find out some updates are needed in breezee's --initialize-virtualenv command.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on a change in pull request #7390:
[AIRFLOW-6764] Fixed environment installation for Linux
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #7390: [AIRFLOW-6764] Fixed environment installation for Linux
URL: https://github.com/apache/airflow/pull/7390#discussion_r376819516
##########
File path: breeze
##########
@@ -904,7 +904,7 @@ if [[ ${INITIALIZE_LOCAL_VIRTUALENV} == "true" ]]; then
if [[ ${SYSTEM} == "Darwin" ]]; then
echo " brew install sqlite mysql postgresql"
else
- echo " sudo apt-get install openssl sqlite libmysqlclient-dev libmysqld-dev postgresql --confirm"
+ echo " sudo apt-get install python3-dev python-dev openssl sqlite default-libmysqlclient-dev libmysqld-dev postgresql --confirm"
Review comment:
Just in case. I want to backport it to 1.10 so I want it to work there as well. There are still some distros that have python2 as default and it will be like that for a while so it's better to leave it like that just in case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] ashb commented on a change in pull request #7390:
[AIRFLOW-6764] Fixed environment installation for Linux
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #7390: [AIRFLOW-6764] Fixed environment installation for Linux
URL: https://github.com/apache/airflow/pull/7390#discussion_r376817321
##########
File path: setup.py
##########
@@ -503,7 +503,7 @@ def do_setup():
# DEPENDENCIES_EPOCH_NUMBER in the Dockerfile
#####################################################################################################
setup_requires=[
- 'docutils>=0.14, <1.0',
+ 'docutils>=0.14, <0.16'
Review comment:
What changed in 0.16?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on a change in pull request #7390:
[AIRFLOW-6764] Fixed environment installation for Linux
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #7390: [AIRFLOW-6764] Fixed environment installation for Linux
URL: https://github.com/apache/airflow/pull/7390#discussion_r376819598
##########
File path: breeze
##########
@@ -904,7 +904,7 @@ if [[ ${INITIALIZE_LOCAL_VIRTUALENV} == "true" ]]; then
if [[ ${SYSTEM} == "Darwin" ]]; then
echo " brew install sqlite mysql postgresql"
else
Review comment:
Yep. but this is Darwin :) =-> MacOS
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on a change in pull request #7390:
[AIRFLOW-6764] Fixed environment installation for Linux
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #7390: [AIRFLOW-6764] Fixed environment installation for Linux
URL: https://github.com/apache/airflow/pull/7390#discussion_r376819338
##########
File path: setup.py
##########
@@ -503,7 +503,7 @@ def do_setup():
# DEPENDENCIES_EPOCH_NUMBER in the Dockerfile
#####################################################################################################
setup_requires=[
- 'docutils>=0.14, <1.0',
+ 'docutils>=0.14, <0.16'
Review comment:
One of our dependencies is incompatible with 0.16 and when you try it on a fresh system you get "incompatibility" problem (not sure which one) - until we fix it with pinnig - it's the simplest way to make it works out-of the box.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] ashb commented on a change in pull request #7390:
[AIRFLOW-6764] Fixed environment installation for Linux
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #7390: [AIRFLOW-6764] Fixed environment installation for Linux
URL: https://github.com/apache/airflow/pull/7390#discussion_r376817357
##########
File path: breeze
##########
@@ -904,7 +904,7 @@ if [[ ${INITIALIZE_LOCAL_VIRTUALENV} == "true" ]]; then
if [[ ${SYSTEM} == "Darwin" ]]; then
echo " brew install sqlite mysql postgresql"
else
Review comment:
There are many more Linuxes than Debian ;)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk merged pull request #7390: [AIRFLOW-6764] Fixed
environment installation for Linux
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #7390: [AIRFLOW-6764] Fixed environment installation for Linux
URL: https://github.com/apache/airflow/pull/7390
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] ashb commented on a change in pull request #7390:
[AIRFLOW-6764] Fixed environment installation for Linux
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #7390: [AIRFLOW-6764] Fixed environment installation for Linux
URL: https://github.com/apache/airflow/pull/7390#discussion_r376817404
##########
File path: breeze
##########
@@ -904,7 +904,7 @@ if [[ ${INITIALIZE_LOCAL_VIRTUALENV} == "true" ]]; then
if [[ ${SYSTEM} == "Darwin" ]]; then
echo " brew install sqlite mysql postgresql"
else
- echo " sudo apt-get install openssl sqlite libmysqlclient-dev libmysqld-dev postgresql --confirm"
+ echo " sudo apt-get install python3-dev python-dev openssl sqlite default-libmysqlclient-dev libmysqld-dev postgresql --confirm"
Review comment:
Why python-dev and python3-dev?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services