You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@trafficserver.apache.org by ma...@apache.org on 2018/01/10 01:27:27 UTC

[trafficserver] branch quic-latest updated: Make sure that loss detection alarm duration is positive value

This is an automated email from the ASF dual-hosted git repository.

maskit pushed a commit to branch quic-latest
in repository https://gitbox.apache.org/repos/asf/trafficserver.git


The following commit(s) were added to refs/heads/quic-latest by this push:
     new b438973  Make sure that loss detection alarm duration is positive value
b438973 is described below

commit b43897362755392e179d1a403d5055bc71583039
Author: Masakazu Kitajo <ma...@apache.org>
AuthorDate: Wed Jan 10 10:26:40 2018 +0900

    Make sure that loss detection alarm duration is positive value
---
 iocore/net/quic/QUICLossDetector.cc | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/iocore/net/quic/QUICLossDetector.cc b/iocore/net/quic/QUICLossDetector.cc
index 9b25f52..3b793ba 100644
--- a/iocore/net/quic/QUICLossDetector.cc
+++ b/iocore/net/quic/QUICLossDetector.cc
@@ -273,6 +273,14 @@ QUICLossDetector::_set_loss_detection_alarm()
     QUICLDDebug("RTO alarm will be set");
   }
 
+  // ADDITIONAL CODE
+  // alarm_curation can be negative value because _loss_time is updated in _detect_lost_packets()
+  // In that case, perhaps we should trigger the alarm immediately.
+  if (alarm_duration < 0) {
+    alarm_duration = 1;
+  }
+  // END OF ADDITONAL CODE
+
   if (this->_loss_detection_alarm_at) {
     this->_loss_detection_alarm_at = std::min(this->_loss_detection_alarm_at, Thread::get_hrtime() + alarm_duration);
   } else {

-- 
To stop receiving notification emails like this one, please contact
['"commits@trafficserver.apache.org" <co...@trafficserver.apache.org>'].