You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/04/22 20:27:14 UTC
[GitHub] [incubator-superset] badman-rodriguez opened a new issue #9625: [superset-frontend] Changes aren't reflected
badman-rodriguez opened a new issue #9625:
URL: https://github.com/apache/incubator-superset/issues/9625
I thought this would be pretty simple... but its weird:
Add a new component in `InsertComponentPane.jsx`
```
<div className={cx('slider-container', this.state.slideDirection)}>
<div className="component-layer slide-content">
<div className="dashboard-builder-sidepane-header">
<span>{t('Insert components')}</span>
<i
className="fa fa-times trigger"
onClick={this.onCloseButtonClick}
role="none"
/>
</div>
<div
className="new-component static"
role="none"
onClick={this.openSlicesPane}
>
<div className="new-component-placeholder fa fa-area-chart" />
<div className="new-component-label">
{t('Your charts & filters')}
</div>
<i className="fa fa-arrow-right trigger" />
</div>
<NewTabs />
<NewRow />
<NewColumn />
<NewHeader />
<NewMarkdown />
<NewDivider />
<NewCard /> <---- NOT VISIBLE AT ALL!!!!!
</div>
<div className="slices-layer slide-content">
<div
className="dashboard-builder-sidepane-header"
onClick={this.closeSlicesPane}
role="none"
>
<i className="fa fa-arrow-left trigger" />
<span>{t('Your charts and filters')}</span>
</div>
<SliceAdder
height={
this.props.height +
(this.props.isSticky ? SUPERSET_HEADER_HEIGHT : 0)
}
/>
</div>
</div>
```
In fact if i delete aall the options... nothing changes here...
So im using these available scripts:
```
"version": "0.999.0dev",
"scripts": {
"tdd": "NODE_ENV=test jest --watch",
"test": "NODE_ENV=test jest",
"cover": "NODE_ENV=test jest --coverage",
"dev": "webpack --mode=development --colors --progress --debug --watch",
"dev-server": "NODE_ENV=development BABEL_ENV=development node ./node_modules/webpack-dev-server/bin/webpack-dev-server.js --mode=development",
"prod": "node --max_old_space_size=4096 ./node_modules/webpack/bin/webpack.js --mode=production",
"build-dev": "cross-env NODE_OPTIONS=--max_old_space_size=8192 NODE_ENV=development webpack --mode=development",
"build": "cross-env NODE_OPTIONS=--max_old_space_size=8192 NODE_ENV=production webpack --mode=production --colors --progress",
"lint": "prettier --check '{src,stylesheets}/**/*.{css,less,sass,scss}' && eslint --ignore-path=.eslintignore --ext .js,.jsx,.ts,.tsx .",
"lint-fix": "eslint --fix --ignore-path=.eslintignore --ext .js,.jsx,.ts,tsx . && npm run clean-css",
"clean-css": "prettier --write '{src,stylesheets}/**/*.{css,less,sass,scss}'"
},
```
what do i need to change in order to see my change locally and not using docker.
Thanks in advance!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] badman-rodriguez commented on issue #9625: [superset-frontend] Changes aren't reflected
Posted by GitBox <gi...@apache.org>.
badman-rodriguez commented on issue #9625:
URL: https://github.com/apache/incubator-superset/issues/9625#issuecomment-619006605
Added info:
Superset with FLASK_ENV = development
```
(venv) xbxr089@C02V27QUHTD5:~/Documents/bloop/superset$ FLASK_ENV=development superset run -p 8088 --with-threads --reload --debugrer
2020-04-24 08:21:58,688:INFO:root:logging was configured successfully
2020-04-24 08:21:59,166:INFO:root:Configured event logger of type <class 'superset.utils.log.DBEventLogger'>
* Serving Flask app "superset" (lazy loading)
* Environment: development
* Debug mode: on
2020-04-24 08:22:02,907:INFO:werkzeug: * Running on http://127.0.0.1:8088/ (Press CTRL+C to quit)
2020-04-24 08:22:02,908:INFO:werkzeug: * Restarting with stat
2020-04-24 08:22:06,516:INFO:root:logging was configured successfully
2020-04-24 08:22:06,999:INFO:root:Configured event logger of type <class 'superset.utils.log.DBEventLogger'>
2020-04-24 08:22:10,947:WARNING:werkzeug: * Debugger is active!
```
Webpack Dev Server
```
> superset@0.999.0-dev dev-server /Users/xbxr089/Documents/bloop/superset/superset-frontend
> NODE_ENV=development BABEL_ENV=development node --max_old_space_size=4096 ./node_modules/webpack-dev-server/bin/webpack-dev-server.js --mode=development --progress
Starting type checking service...
Using 1 worker with 2048MB memory limit
12% building 17/17 modules 0 active[HPM] Proxy created: / -> http://localhost:8088
ℹ ｢wds｣: Project is running at http://localhost:9000/
ℹ ｢wds｣: webpack output is served from /static/assets/
ℹ ｢wds｣: Content not from webpack is served from /Users/xbxr089/Documents/bloop/superset/static/assets
ℹ ｢wds｣: 404s will fallback to /index.html
98% after emitting SizeLimitsPluginNo type errors found
Version: typescript 3.8.3
Time: 32587ms
ℹ ｢wdm｣: 5557 modules
ℹ ｢wdm｣: Compiled successfully.
[HPM] Proxy created: / -> http://localhost:8088
```
I save changes, webpack dev server picks it up and no luck. nothing reflects.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] badman-rodriguez commented on issue #9625: [superset-frontend] Changes aren't reflected
Posted by GitBox <gi...@apache.org>.
badman-rodriguez commented on issue #9625:
URL: https://github.com/apache/incubator-superset/issues/9625#issuecomment-620570286
It looks like webpack dev ser isnt loading anything
<img width="430" alt="Screen Shot 2020-04-28 at 7 16 47 AM" src="https://user-images.githubusercontent.com/15989103/80486336-99c4ed00-8920-11ea-8ee1-53c3e9467a0e.png">
vs what it should look like:
<img width="375" alt="Screen Shot 2020-04-28 at 7 04 09 AM" src="https://user-images.githubusercontent.com/15989103/80486362-a8130900-8920-11ea-9315-752ca554c145.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] badman-rodriguez commented on issue #9625: [superset-frontend] Changes aren't reflected
Posted by GitBox <gi...@apache.org>.
badman-rodriguez commented on issue #9625:
URL: https://github.com/apache/incubator-superset/issues/9625#issuecomment-623509988
Im currently rebuilding the webpack config from scratch to get this working. Will update the bug ticket as soon as im done with it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org