[GitHub] [ignite-3] AMashenkov commented on a change in pull request #497: IGNITE-14971 Thin client: Add RecordView

[GitBox <gi...@apache.org>]

AMashenkov commented on a change in pull request #497:
URL: https://github.com/apache/ignite-3/pull/497#discussion_r765629731



##########
File path: modules/client/src/main/java/org/apache/ignite/internal/client/table/ClientSchema.java
##########
@@ -39,6 +65,15 @@
     /** Columns map by name. */
     private final Map<String, ClientColumn> map = new HashMap<>();
 
+    /** Marshaller cache. */
+    private final Map<Mapper, Marshaller> marshallers = new ConcurrentHashMap<>();
+
+    /** Marshaller cache. */
+    private final Map<Mapper, Marshaller> keyMarshallers = new ConcurrentHashMap<>();
+
+    /** Marshaller cache. */
+    private final Map<Mapper, Marshaller> valMarshallers = new ConcurrentHashMap<>();

Review comment:
       What about cache invalidation?
   Mapper doesn't implement hashcode/equals., so using mapper builder will bloat the cache.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org