[jira] [Commented] (FLINK-11080) Define flink-connector-elasticsearch6 uber-jar dependencies via artifactSet

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-11080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16710164#comment-16710164 ] 

ASF GitHub Bot commented on FLINK-11080:
----------------------------------------

zentol opened a new pull request #7247: [FLINK-11080][ES] Rework shade-plugin filters
URL: https://github.com/apache/flink/pull/7247
 
 
   ## What is the purpose of the change
   
   This PR reworks the shade-plugin filtering for the elasticsearch6 connector. The existing approach was rather obscure and not really maintainable.
   
   ## Brief change log
   
   Filters that were excluding entire dependencies (or rather _tried_ to do so...) were replaced with an artifact exclusions.
   Filters that excluded parts of a single dependency were kept as a filter, but scoped that specific dependency.
   
   ## Verifying this change
   
   Manually verified. The class contents are identical, but the META-INF directory is now smaller since dependencies are properly excluded.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Define flink-connector-elasticsearch6 uber-jar dependencies via artifactSet
> ---------------------------------------------------------------------------
>
>                 Key: FLINK-11080
>                 URL: https://issues.apache.org/jira/browse/FLINK-11080
>             Project: Flink
>          Issue Type: Improvement
>          Components: ElasticSearch Connector, SQL Client
>    Affects Versions: 1.5.5, 1.6.2, 1.7.0
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.5.6, 1.6.3, 1.8.0, 1.7.1
>
>
> Similar to FLINK-11005.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)