You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/02/08 01:09:26 UTC
[GitHub] [airflow] blag opened a new pull request #21406: Tweak origin parameter
blag opened a new pull request #21406:
URL: https://github.com/apache/airflow/pull/21406
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
This is a simpler alternative to #21310.
The `origin` parameter is used to take users back to a previous page they were on. This PR fixes the way this parameter was handled.
The tiny [`html`](https://docs.python.org/3/library/html.html) library was added in Python 3.2 and expanded in Python 3.4.
I changed the `<button class="btn">` to a normal `<a class="btn">`, since it is more appropriate. The [commit](https://github.com/apache/airflow/pull/11195/files#diff-c7993103f49b0ad44fbe04d22a72f17989dd8908efd88c2ee92ce47ae21dc3c4R37) that introduced the `<button class="btn">` behavior was part of the [2.0 UI refresh PR](https://github.com/apache/airflow/pull/11195).
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham closed pull request #21406: Tweak origin parameter
Posted by GitBox <gi...@apache.org>.
jedcunningham closed pull request #21406:
URL: https://github.com/apache/airflow/pull/21406
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a change in pull request #21406: Tweak origin parameter
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #21406:
URL: https://github.com/apache/airflow/pull/21406#discussion_r801480917
##########
File path: airflow/www/views.py
##########
@@ -1760,6 +1761,7 @@ def trigger(self, session=None):
'airflow/trigger.html',
dag_id=dag_id,
origin=origin,
+ html_attr_escaped_origin=html.escape(origin, quote=True),
Review comment:
I don't see where this value is used in templates? Have I just missed it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham closed pull request #21406: Tweak origin parameter
Posted by GitBox <gi...@apache.org>.
jedcunningham closed pull request #21406:
URL: https://github.com/apache/airflow/pull/21406
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on pull request #21406: Tweak origin parameter
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on pull request #21406:
URL: https://github.com/apache/airflow/pull/21406#issuecomment-1040602755
Superseded by #21591.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] blag commented on a change in pull request #21406: Tweak origin parameter
Posted by GitBox <gi...@apache.org>.
blag commented on a change in pull request #21406:
URL: https://github.com/apache/airflow/pull/21406#discussion_r801932092
##########
File path: airflow/www/views.py
##########
@@ -1760,6 +1761,7 @@ def trigger(self, session=None):
'airflow/trigger.html',
dag_id=dag_id,
origin=origin,
+ html_attr_escaped_origin=html.escape(origin, quote=True),
Review comment:
You didn't miss it, I just messed up my rebase. Fixing now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on pull request #21406: Tweak origin parameter
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on pull request #21406:
URL: https://github.com/apache/airflow/pull/21406#issuecomment-1040602755
Superseded by #21591.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org