You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/11/24 10:30:32 UTC

[GitHub] [doris] eldenmoon commented on a diff in pull request #14552: [Fix](function) Fix sequence function return wrong value type

eldenmoon commented on code in PR #14552:
URL: https://github.com/apache/doris/pull/14552#discussion_r1031348063


##########
fe/fe-core/src/main/java/org/apache/doris/catalog/FunctionSet.java:
##########
@@ -1476,7 +1476,7 @@ private void initAggregateBuiltins() {
         // retention vectorization
         addBuiltin(AggregateFunction.createBuiltin(FunctionSet.RETENTION,
                 Lists.newArrayList(Type.BOOLEAN),
-                new ArrayType(Type.BOOLEAN),
+                new ArrayType(Type.TINYINT),

Review Comment:
   add comment to explain why use TINY INT?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org