You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flex.apache.org by Pepe <pe...@gmail.com> on 2012/04/05 14:04:27 UTC

performance issues of tab movement in s:DataGrid of Flex 4.6

Hello

I found an issue on item editors movement by TAB key.
In mx:DataGrid, it moves quickly. However, I feel it's slow in s:DataGrid.
I investigated source of classes related with s:DataGrid a little.

I found three factors.

  1) s:GridItemEditor uses s:TextArea
   2) grid.focusManager.getNextFocusManagerComponent takes dozens of
milliseconds in editor_keyFocusChangeHandler function of
s:DataGridEditor
   3) it calls the validateNow method in do while loop at
ensureCellIsVisible function of s:Grid

We can avoid 1) by using custom light-weight editor. But we can't
avoid 2) and 3).

Why is 2) needed?

It takes 10% of CPU resources at each TAB key movement of itemEditors
because the validateNow is called.
When I comment out 3), the focus moves incorrectly at rendererIsEditor column.
However, there should be other ways without calling validateNow.


thanks

Shigeru Nakagaki

Re: performance issues of tab movement in s:DataGrid of Flex 4.6

Posted by Pepe <pe...@gmail.com>.
Hi, Carol

I'm talking about s:DataGrid.
I believe it doesn't need to call validateNow many times in one logic
flow and validateNow makes performance issue in big component.

I really hope it will be fixed in next release.


thanks

Shigeru Nakagaki


2012/4/5 Carol Frampton <cf...@adobe.com>:
> One of you is talking about s:DataGrid and one of you is talking about
> mx:AdvancedDataGrid.  Not sure it is the same issue.
>
> Carol
>
> On 4/5/12 9 :15AM, "Justin Mclean" <ju...@classsoftware.com> wrote:
>
>>Hi,
>>
>>There a known issue with invalidateNow being call too often in the ADG.
>>Once we have Mustella I have a patch that can be applied.
>>
>>Thanks,
>>Justin
>>
>>> Hello
>>>
>>> I found an issue on item editors movement by TAB key.
>>> In mx:DataGrid, it moves quickly. However, I feel it's slow in
>>>s:DataGrid.
>>> I investigated source of classes related with s:DataGrid a little.
>>>
>>> I found three factors.
>>>
>>>  1) s:GridItemEditor uses s:TextArea
>>>   2) grid.focusManager.getNextFocusManagerComponent takes dozens of
>>> milliseconds in editor_keyFocusChangeHandler function of
>>> s:DataGridEditor
>>>   3) it calls the validateNow method in do while loop at
>>> ensureCellIsVisible function of s:Grid
>>>
>>> We can avoid 1) by using custom light-weight editor. But we can't
>>> avoid 2) and 3).
>>>
>>> Why is 2) needed?
>>>
>>> It takes 10% of CPU resources at each TAB key movement of itemEditors
>>> because the validateNow is called.
>>> When I comment out 3), the focus moves incorrectly at rendererIsEditor
>>>column.
>>> However, there should be other ways without calling validateNow.
>>>
>>>
>>> thanks
>>>
>>> Shigeru Nakagaki
>>
>

Re: performance issues of tab movement in s:DataGrid of Flex 4.6

Posted by Carol Frampton <cf...@adobe.com>.
One of you is talking about s:DataGrid and one of you is talking about
mx:AdvancedDataGrid.  Not sure it is the same issue.

Carol

On 4/5/12 9 :15AM, "Justin Mclean" <ju...@classsoftware.com> wrote:

>Hi,
>
>There a known issue with invalidateNow being call too often in the ADG.
>Once we have Mustella I have a patch that can be applied.
>
>Thanks,
>Justin
>
>> Hello
>> 
>> I found an issue on item editors movement by TAB key.
>> In mx:DataGrid, it moves quickly. However, I feel it's slow in
>>s:DataGrid.
>> I investigated source of classes related with s:DataGrid a little.
>> 
>> I found three factors.
>> 
>>  1) s:GridItemEditor uses s:TextArea
>>   2) grid.focusManager.getNextFocusManagerComponent takes dozens of
>> milliseconds in editor_keyFocusChangeHandler function of
>> s:DataGridEditor
>>   3) it calls the validateNow method in do while loop at
>> ensureCellIsVisible function of s:Grid
>> 
>> We can avoid 1) by using custom light-weight editor. But we can't
>> avoid 2) and 3).
>> 
>> Why is 2) needed?
>> 
>> It takes 10% of CPU resources at each TAB key movement of itemEditors
>> because the validateNow is called.
>> When I comment out 3), the focus moves incorrectly at rendererIsEditor
>>column.
>> However, there should be other ways without calling validateNow.
>> 
>> 
>> thanks
>> 
>> Shigeru Nakagaki
>

Re: performance issues of tab movement in s:DataGrid of Flex 4.6

Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,

There a known issue with invalidateNow being call too often in the ADG. Once we have Mustella I have a patch that can be applied.

Thanks,
Justin

> Hello
> 
> I found an issue on item editors movement by TAB key.
> In mx:DataGrid, it moves quickly. However, I feel it's slow in s:DataGrid.
> I investigated source of classes related with s:DataGrid a little.
> 
> I found three factors.
> 
>  1) s:GridItemEditor uses s:TextArea
>   2) grid.focusManager.getNextFocusManagerComponent takes dozens of
> milliseconds in editor_keyFocusChangeHandler function of
> s:DataGridEditor
>   3) it calls the validateNow method in do while loop at
> ensureCellIsVisible function of s:Grid
> 
> We can avoid 1) by using custom light-weight editor. But we can't
> avoid 2) and 3).
> 
> Why is 2) needed?
> 
> It takes 10% of CPU resources at each TAB key movement of itemEditors
> because the validateNow is called.
> When I comment out 3), the focus moves incorrectly at rendererIsEditor column.
> However, there should be other ways without calling validateNow.
> 
> 
> thanks
> 
> Shigeru Nakagaki