You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2021/11/02 15:35:38 UTC

[GitHub] [trafficcontrol] ocket8888 opened a new pull request #6322: Fix GHA that checks db migration filenames to properly check timestamp digits

ocket8888 opened a new pull request #6322:
URL: https://github.com/apache/trafficcontrol/pull/6322


   At some point our GHA that is supposed to ensure the proper number of digits for database migration file name timestamps broke and allowed in something that should've been invalid in #6307. This PR fixes the GHA to properly mark those files as in violation of the naming scheme.
   
   <hr>
   
   ## Which Traffic Control components are affected by this PR?
   - Automation (GitHub Actions)
   
   ## What is the best way to verify this PR?
   This PR _should_ fail that check, because our master branch currently _should_ fail that check but doesn't - that's the bug this fixes. If you create a new branch on your fork based on this branch, delete the migration files added in #6307, then push, the check should pass (though others may fail).
   
   ## If this is a bugfix, which Traffic Control versions contained the bug?
   - master
   
   ## PR submission checklist
   - [x] This PR fixes tests
   - [x] This PR has no documentation
   - [x] This PR has no CHANGELOG.md entry
   - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY**


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficcontrol] zrhoffman merged pull request #6322: Fix GHA that checks db migration filenames to properly check timestamp digits

Posted by GitBox <gi...@apache.org>.
zrhoffman merged pull request #6322:
URL: https://github.com/apache/trafficcontrol/pull/6322


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficcontrol] zrhoffman merged pull request #6322: Fix GHA that checks db migration filenames to properly check timestamp digits

Posted by GitBox <gi...@apache.org>.
zrhoffman merged pull request #6322:
URL: https://github.com/apache/trafficcontrol/pull/6322


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficcontrol] zrhoffman merged pull request #6322: Fix GHA that checks db migration filenames to properly check timestamp digits

Posted by GitBox <gi...@apache.org>.
zrhoffman merged pull request #6322:
URL: https://github.com/apache/trafficcontrol/pull/6322


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org