You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/02/19 19:34:18 UTC
[jira] [Commented] (GEODE-52) Remove @author tags from Java source
[ https://issues.apache.org/jira/browse/GEODE-52?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15154607#comment-15154607 ]
ASF GitHub Bot commented on GEODE-52:
-------------------------------------
GitHub user sboorlagadda opened a pull request:
https://github.com/apache/incubator-geode/pull/100
GEODE-52: Remove @author tags from Java source
* removed @author tags except from java source copied from JSON.org
* removed @author from java script files.
I have automatically removed @author tags using unix command ` find . -type f -print0 | xargs -0 sed -i /@author/d`
I tested gradle build to check any compilation issues due to auto-remove a line from headers.
Also precheckin passed.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sboorlagadda/incubator-geode GEODE-52
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-geode/pull/100.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #100
----
commit 15aeb81376dd7c4edd7a2a41ae9a9f261956f769
Author: Sai Boorlagadda <sb...@pivotal.io>
Date: 2016-02-17T22:51:44Z
GEODE-52: Remove @author tags from Java source
* removed @author tags except from java source copied from JSON.org
commit 2b1c405745248e465debd8afe9d8e1b9acc75bf4
Author: Sai Boorlagadda <sb...@pivotal.io>
Date: 2016-02-18T20:24:59Z
GEODE-52: Remove @author tags from Java source
* removed @author from java script files.
----
> Remove @author tags from Java source
> ------------------------------------
>
> Key: GEODE-52
> URL: https://issues.apache.org/jira/browse/GEODE-52
> Project: Geode
> Issue Type: Bug
> Reporter: Jakob Homan
> Assignee: Sai Boorlagadda
>
> Apache generally frowns on @author tags (as they imply ownership of the code by a single individual, see https://blogs.oracle.com/ahe/entry/coding_conventions_and_attribution [best asf link is not working, annoyingly] and https://cwiki.apache.org/confluence/display/AVRO/How+To+Contribute as an example)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)