You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/10/28 14:03:05 UTC

[GitHub] [spark] MaxGekk commented on a diff in pull request #38286: [SPARK-40657] Add support for Java classes in Protobuf functions

MaxGekk commented on code in PR #38286:
URL: https://github.com/apache/spark/pull/38286#discussion_r1008102188


##########
connector/protobuf/src/test/scala/org/apache/spark/sql/protobuf/ProtobufCatalystDataConversionSuite.scala:
##########
@@ -24,6 +24,7 @@ import org.apache.spark.sql.{RandomDataGenerator, Row}
 import org.apache.spark.sql.catalyst.{CatalystTypeConverters, InternalRow, NoopFilters, OrderedFilters, StructFilters}
 import org.apache.spark.sql.catalyst.expressions.{ExpressionEvalHelper, GenericInternalRow, Literal}
 import org.apache.spark.sql.catalyst.util.{ArrayBasedMapData, GenericArrayData, MapData}
+import org.apache.spark.sql.protobuf.protos.CatalystTypes.BytesMsg

Review Comment:
   I am struggling in generating this file in IDEA:
   <img width="1027" alt="Screenshot 2022-10-28 at 17 02 04" src="https://user-images.githubusercontent.com/1580697/198630233-33341e69-276f-4505-9d52-874ddd1e6bc1.png">
   
   Is any way to generate all required dependencies?
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org