[GitHub] [spark] HyukjinKwon commented on a diff in pull request #42120: [SPARK-44509][PYTHON][CONNECT] Add job cancellation API set in Spark Connect Python client

["HyukjinKwon (via GitHub)" <gi...@apache.org>]

HyukjinKwon commented on code in PR #42120:
URL: https://github.com/apache/spark/pull/42120#discussion_r1272933655


##########
python/pyspark/sql/connect/client/core.py:
##########
@@ -574,6 +576,8 @@ def __init__(
             the $USER environment. Defining the user ID as part of the connection string
             takes precedence.
         """
+        self.thread_local = threading.local()

Review Comment:
   BTW, there is difference here. Python's threadlocal isn't inheritable (and there's no such implementation in Python). So we should somehow workaround this ...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org