You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/10/09 10:02:00 UTC
[GitHub] [superset] stephenLYZ opened a new pull request, #21748: chore(deps): bump react-map-gl from 4.0.10 to 6.1.19
stephenLYZ opened a new pull request, #21748:
URL: https://github.com/apache/superset/pull/21748
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Since there is "Prototype Pollution" in minimist(< 1.2.6), we need to upgrade to 1.2.6. Currently we have two dependecy chains:
- minimist (0.0.5) -> sharkdown -> @mapbox/geojson-rewind -> mapbox-gl(0.53.1)
- minimist (0.0.8) -> react-map-gl (4.1.16) -> mapbox-gl(0.54.1)
So just upgrade react-map-gl can resolve the issue. However, react-map-gl has break change in version 7, we upgrade to version 6 to avoid major changes。
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] EugeneTorap commented on pull request #21748: chore(deps): bump react-map-gl from 4.0.10 to 6.1.19
Posted by GitBox <gi...@apache.org>.
EugeneTorap commented on PR #21748:
URL: https://github.com/apache/superset/pull/21748#issuecomment-1272536352
@stephenLYZ Can we try to update `react-map-gl` to version 7 in the future in order to minimize our JS bundle?
### **Version 6 - 1.81 MB**
### **Version 7 - 410 kB**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] EugeneTorap commented on a diff in pull request #21748: chore(deps): bump react-map-gl from 4.0.10 to 6.1.19
Posted by GitBox <gi...@apache.org>.
EugeneTorap commented on code in PR #21748:
URL: https://github.com/apache/superset/pull/21748#discussion_r990782702
##########
superset-frontend/package-lock.json:
##########
@@ -45172,16 +45160,18 @@
}
},
"node_modules/react-map-gl": {
- "version": "4.1.16",
- "resolved": "https://registry.npmjs.org/react-map-gl/-/react-map-gl-4.1.16.tgz",
- "integrity": "sha512-EtiHCeqM69wKR9RDyLvtk6pTPS5+OFeAPIsYw6afnlGTauFAq3iD40SHuAOElgoJmm7J+cjPfHqu7m7tB4/FfA==",
+ "version": "6.1.19",
+ "resolved": "https://registry.npmjs.org/react-map-gl/-/react-map-gl-6.1.19.tgz",
+ "integrity": "sha512-rrDoRyEIGzVLUB5QfgsZ5xCw7jeUtmmYzHUv86xDx8oGp90VTV2KTQJ4RPQiSAmpfIFh6/pPqI28Pguf1u/mOg==",
"dependencies": {
"@babel/runtime": "^7.0.0",
- "mapbox-gl": "~0.54.0",
- "mjolnir.js": "^2.2.0",
+ "@types/geojson": "^7946.0.7",
+ "@types/mapbox-gl": "^2.0.3",
+ "mapbox-gl": "^2.3.0",
+ "mjolnir.js": "^2.5.0",
"prop-types": "^15.7.2",
- "react-virtualized-auto-sizer": "^1.0.2",
Review Comment:
If you see `react-virtualized-auto-sizer` is removed in `react-map-gl`
Can you remove `"react-virtualized-auto-sizer": "^1.0.2",` in package.json? Because this lib no longer used anywhere
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] stephenLYZ commented on pull request #21748: chore(deps): bump react-map-gl from 4.0.10 to 6.1.19
Posted by GitBox <gi...@apache.org>.
stephenLYZ commented on PR #21748:
URL: https://github.com/apache/superset/pull/21748#issuecomment-1272814805
> @stephenLYZ Can we try to update `react-map-gl` to version 7 in the future in order to minimize our JS bundle?
>
> ### **Version 6 - 1.81 MB**
> 
>
> ### **Version 7 - 410 kB**
> 
Yeah. The main chart involved is mapbox, which will probably be rewritten in version 7. Let's do it in the another PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #21748: chore(deps): bump react-map-gl from 4.0.10 to 6.1.19
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #21748:
URL: https://github.com/apache/superset/pull/21748#issuecomment-1274164254
Ephemeral environment shutdown and build artifacts deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on pull request #21748: chore(deps): bump react-map-gl from 4.0.10 to 6.1.19
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on PR #21748:
URL: https://github.com/apache/superset/pull/21748#issuecomment-1272529672
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] stephenLYZ merged pull request #21748: chore(deps): bump react-map-gl from 4.0.10 to 6.1.19
Posted by GitBox <gi...@apache.org>.
stephenLYZ merged PR #21748:
URL: https://github.com/apache/superset/pull/21748
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #21748: chore(deps): bump react-map-gl from 4.0.10 to 6.1.19
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #21748:
URL: https://github.com/apache/superset/pull/21748#issuecomment-1272530010
@zhaoyongjie Ephemeral environment spinning up at http://34.222.28.62:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #21748: chore(deps): bump react-map-gl from 4.0.10 to 6.1.19
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #21748:
URL: https://github.com/apache/superset/pull/21748#issuecomment-1272514447
# [Codecov](https://codecov.io/gh/apache/superset/pull/21748?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#21748](https://codecov.io/gh/apache/superset/pull/21748?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8c0f484) into [master](https://codecov.io/gh/apache/superset/commit/f58227a9124866d1db0dcb20947e9bee287ba0fc?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f58227a) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #21748 +/- ##
=======================================
Coverage 66.84% 66.84%
=======================================
Files 1800 1800
Lines 68951 68951
Branches 7335 7335
=======================================
Hits 46092 46092
- Misses 20965 20966 +1
+ Partials 1894 1893 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `53.16% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/21748?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...nts/controls/DateFilterControl/DateFilterLabel.tsx](https://codecov.io/gh/apache/superset/pull/21748/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9EYXRlRmlsdGVyTGFiZWwudHN4) | `41.41% <0.00%> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org