You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/07/24 02:53:03 UTC
[GitHub] [kafka] showuon opened a new pull request #11122: MINOR: remove unneeded comments to avoid misleading message
showuon opened a new pull request #11122:
URL: https://github.com/apache/kafka/pull/11122
Found this comments left while we updating the PR: https://github.com/apache/kafka/pull/11057. We don't do deduplicate in Fetcher anymore, this comment should be removed to avoid misleading other people.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #11122: MINOR: remove unneeded comments to avoid misleading message
Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #11122:
URL: https://github.com/apache/kafka/pull/11122#issuecomment-885990340
@guozhangwang , sorry, I finally got time to check the updated PR: #11057, and found we forgot to remove this comment. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] guozhangwang commented on pull request #11122: MINOR: remove unneeded comments to avoid misleading message
Posted by GitBox <gi...@apache.org>.
guozhangwang commented on pull request #11122:
URL: https://github.com/apache/kafka/pull/11122#issuecomment-885992700
Thanks @showuon ! Cherry-picked to 3.0 as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] guozhangwang merged pull request #11122: MINOR: remove unneeded comments to avoid misleading message
Posted by GitBox <gi...@apache.org>.
guozhangwang merged pull request #11122:
URL: https://github.com/apache/kafka/pull/11122
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org