[GitHub] [incubator-daffodil] mbeckerle commented on a change in pull request #289: Daffodil 2192 warnings - nextElementResolver rewrite

[GitBox <gi...@apache.org>]

mbeckerle commented on a change in pull request #289: Daffodil 2192 warnings - nextElementResolver rewrite
URL: https://github.com/apache/incubator-daffodil/pull/289#discussion_r346855375
 
 

 ##########
 File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/ParticleMixin.scala
 ##########
 @@ -85,12 +85,16 @@ trait RequiredOptionalMixin { self: ElementBase =>
    * Takes into account that some dfdl:occursCountKind can make
    * seemingly required elements (based on minOccurs) optional or
    * repeating.
+   *
+   * OutputValueCalc elements are treated as optional. If present they are supposed to get their
+   * values ignored and overwritten by the computation.
    */
   final lazy val isRequiredInInfoset: Boolean = {
     val res = {
-      if (isScalar) true
+      if (isScalar) !this.isOutputValueCalc
 
 Review comment:
   How about isRequiredStreamingUnparserEvent ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services