[GitHub] haojin2 edited a comment on issue #12557: Fix for flaky test_operator_gpu.test_spatial_transformer_with_type

[GitBox <gi...@apache.org>]

haojin2 edited a comment on issue #12557: Fix for flaky test_operator_gpu.test_spatial_transformer_with_type
URL: https://github.com/apache/incubator-mxnet/pull/12557#issuecomment-421480089
 
 
   @ThomasDelteil `cudnn_off` is more of a testing functionality which allows us to compare all versions (in-house CPU, in-house GPU, CuDNN) without re-building the package, but sometimes if users are not satisfied with CuDNN for some reason they can also use that in their code. I think you got the idea behind the change to GPU impl. I'm not familiar with the operator either but we know we should give same results from all 3 version and the GPU one is violating that rule, so after comparison I found that GPU code is a bit different, thus the change.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services