You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/08/15 04:35:40 UTC

[GitHub] Oh233 opened a new pull request #12178: fix flasky unittest for deformable psroi pooling

Oh233 opened a new pull request #12178: fix flasky unittest for deformable psroi pooling
URL: https://github.com/apache/incubator-mxnet/pull/12178
 
 
   ## Description ##
   This PR aims to fix the problem raised by issue #11713. 
   
   ## Checklist ##
   ### Essentials ###
   - [x] Changes are complete (i.e. I finished coding on this PR)
   - [x] All changes have test coverage:
   - Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
   - [x] Code is well-documented: 
   - [x] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
   
   ### Changes ###
   The deformable ps roi pooling operator includes several corner cases which the function is not differentiable. Therefore during the unittest, we need to add some check to ensure the input values are within the smooth regions.
   
   ## Comments ##
   The issue and solution are discussed with @ankkhedia, @sandeep-krishnamurthy, @YuwenXiong and the fix is ran by @ankkhedia for about 2500 times on his local machine.
   
   @ankkhedia could you help review it?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services