[GitHub] [dubbo-go-hessian2] micln opened pull request #150: fix issue 149 - embed struct

["micln (GitHub)" <gi...@apache.org>]

<!--  Thanks for sending a pull request! 
-->

**What this PR does**:

fix issue #149 

**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes #

**Special notes for your reviewer**:

**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note

```

[ Full content available at: https://github.com/apache/dubbo-go-hessian2/pull/150 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go-hessian2] micln commented on pull request #150: fix issue 149 - embed struct

["micln (GitHub)" <gi...@apache.org>]

Is it necessary to return error ?

for example, the server api upgrade and add a new field, the client code would upgrade later. between this time, the client will don't work 

[ Full content available at: https://github.com/apache/dubbo-go-hessian2/pull/150 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go-hessian2] wongoo commented on pull request #150: fix issue 149 - embed struct

["wongoo (GitHub)" <gi...@apache.org>]

yes， gohessian can ignore fields, but not the default behavior,  to do that u should check decoder.isSkip

[ Full content available at: https://github.com/apache/dubbo-go-hessian2/pull/150 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go-hessian2] micln commented on pull request #150: fix issue 149 - embed struct

["micln (GitHub)" <gi...@apache.org>]

another case, if json bytes has more fields, json.unmarshal will ignore the unused fields and don't report any error. 

[ Full content available at: https://github.com/apache/dubbo-go-hessian2/pull/150 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go-hessian2] wongoo commented on pull request #150: fix issue 149 - embed struct

["wongoo (GitHub)" <gi...@apache.org>]

not like json or pb, hessian can't ignore fields, return error is necessary.

[ Full content available at: https://github.com/apache/dubbo-go-hessian2/pull/150 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go-hessian2] wongoo commented on issue #150: fix issue 149 - embed struct

["wongoo (GitHub)" <gi...@apache.org>]

@fangyincheng  review this pr when having time

[ Full content available at: https://github.com/apache/dubbo-go-hessian2/pull/150 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go-hessian2] wongoo closed pull request #150: fix issue 149 - embed struct

["wongoo (GitHub)" <gi...@apache.org>]

[ pull request closed by wongoo ]

[ Full content available at: https://github.com/apache/dubbo-go-hessian2/pull/150 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org