You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by Piero Sartini <li...@pierosartini.de> on 2008/11/17 02:13:23 UTC

Submit button not working (type="input")

using simple theme, <@s.submit /> fails .. nothing is rendered.

If I am using type="button" it seems to work:
<@s.submit type ="button">Submit</...@s.submit>

Is this intended? It seems that the submit.ftl template is not used at all if 
type is not set to "button".

There already was a problem some time ago, don't know if this is related (see 
my comment):
-> https://issues.apache.org/struts/browse/WW-1677

	Piero

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org


Re: Submit button not working (type="input")

Posted by Piero Sartini <li...@pierosartini.de>.
> Fixed on trunk. 

Thanks :) I will test it tomorrow.

> Now comes the funny part, after fixing this I realized that
> it should had been failing for jsps also, but it obviously wasn't and I
> don't know why :)

Sounds like a lot of fun :/

	Piero


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org


Re: Submit button not working (type="input")

Posted by Musachy Barroso <mu...@gmail.com>.
Fixed on trunk. Now comes the funny part, after fixing this I realized that
it should had been failing for jsps also, but it obviously wasn't and I
don't know why :)

thanks for reporting
musachy

On Mon, Nov 17, 2008 at 1:26 PM, Musachy Barroso <mu...@gmail.com> wrote:

> hum...that makes more sense.
>
> musachy
>
>
> On Mon, Nov 17, 2008 at 1:07 PM, Piero Sartini <li...@pierosartini.de>wrote:
>
>> uh.. no attachements allowed?
>>
>> here it is:
>> webapp/tags/ui/example.ftl
>> ----
>> <html>
>> <head>
>>    <title>UI Tags Example</title>
>> </head>
>>
>> <body>
>>
>> <@s.form action="exampleSubmit" enctype="multipart/form-data"
>> javascriptTooltip="true" >
>>    <@s.textfield
>>            label="Name"
>>            name="name"
>>            tooltip="Enter your Name here"/>
>>
>>
>>    <@s.submit />
>>    <@s.reset onclick="alert('Resetting form now... Press OK to
>> continue!');"
>> />
>> </...@s.form>
>>
>> </body>
>> </html>
>> ----
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> For additional commands, e-mail: dev-help@struts.apache.org
>>
>>
>
>
> --
> "Hey you! Would you help me to carry the stone?" Pink Floyd
>



-- 
"Hey you! Would you help me to carry the stone?" Pink Floyd

Re: Submit button not working (type="input")

Posted by Musachy Barroso <mu...@gmail.com>.
hum...that makes more sense.

musachy

On Mon, Nov 17, 2008 at 1:07 PM, Piero Sartini <li...@pierosartini.de>wrote:

> uh.. no attachements allowed?
>
> here it is:
> webapp/tags/ui/example.ftl
> ----
> <html>
> <head>
>    <title>UI Tags Example</title>
> </head>
>
> <body>
>
> <@s.form action="exampleSubmit" enctype="multipart/form-data"
> javascriptTooltip="true" >
>    <@s.textfield
>            label="Name"
>            name="name"
>            tooltip="Enter your Name here"/>
>
>
>    <@s.submit />
>    <@s.reset onclick="alert('Resetting form now... Press OK to
> continue!');"
> />
> </...@s.form>
>
> </body>
> </html>
> ----
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>


-- 
"Hey you! Would you help me to carry the stone?" Pink Floyd

Re: Submit button not working (type="input")

Posted by Piero Sartini <li...@pierosartini.de>.
uh.. no attachements allowed?

here it is:
webapp/tags/ui/example.ftl
----
<html>
<head>
    <title>UI Tags Example</title>
</head>

<body>

<@s.form action="exampleSubmit" enctype="multipart/form-data" 
javascriptTooltip="true" >
    <@s.textfield
            label="Name"
            name="name"
            tooltip="Enter your Name here"/>


    <@s.submit />
    <@s.reset onclick="alert('Resetting form now... Press OK to continue!');" 
/>
</...@s.form>

</body>
</html>
----

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org


Re: Submit button not working (type="input")

Posted by Piero Sartini <li...@pierosartini.de>.
Hello, thanks for taking a look.
The showcase does work for me as well.

After testing around it seems to be a freemarker only issue. I did create a 
simple example.ftl and changed the xml. The submit button disappears.

You find my example.ftl attached to this email. The XML description in struts-
tags-ui.xml looks like this:
---
        <action name="example" 
class="org.apache.struts2.showcase.UITagExample">
            <result>example.ftl</result>
            <result type="freemarker" name="input">example.ftl</result>
        </action>
---

Hope you can reproduce it.

	Piero

Am Montag 17 November 2008 17:55:35 schrieb Musachy Barroso:
> It seems to be ok, I looked at
> apps\showcase\src\main\webapp\tags\ui\example.jsp in showcase, and the
> submit button is showing up fine on this url:
>
> http://localhost:8080/tags/ui/example!input.action
>
> can you check it out?
> musachy
>
> On Sun, Nov 16, 2008 at 9:52 PM, Musachy Barroso <mu...@gmail.com> wrote:
> >> Is this intended? It seems that the submit.ftl template is not used at
> >> all if
> >> type is not set to "button".
> >
> > Nope, it is probably a bug, tt is kind of weird that the testcases didn't
> > fail, if that is the case. I will take a look at it tomorrow.
> > thanks
> > musachy
> > --
> > "Hey you! Would you help me to carry the stone?" Pink Floyd



Re: Submit button not working (type="input")

Posted by Musachy Barroso <mu...@gmail.com>.
It seems to be ok, I looked at
apps\showcase\src\main\webapp\tags\ui\example.jsp in showcase, and the
submit button is showing up fine on this url:

http://localhost:8080/tags/ui/example!input.action

can you check it out?
musachy

On Sun, Nov 16, 2008 at 9:52 PM, Musachy Barroso <mu...@gmail.com> wrote:

>
>> Is this intended? It seems that the submit.ftl template is not used at all
>> if
>> type is not set to "button".
>>
>
> Nope, it is probably a bug, tt is kind of weird that the testcases didn't
> fail, if that is the case. I will take a look at it tomorrow.
> thanks
> musachy
> --
> "Hey you! Would you help me to carry the stone?" Pink Floyd
>



-- 
"Hey you! Would you help me to carry the stone?" Pink Floyd

Re: Submit button not working (type="input")

Posted by Musachy Barroso <mu...@gmail.com>.
>
>
> Is this intended? It seems that the submit.ftl template is not used at all
> if
> type is not set to "button".
>

Nope, it is probably a bug, tt is kind of weird that the testcases didn't
fail, if that is the case. I will take a look at it tomorrow.
thanks
musachy
-- 
"Hey you! Would you help me to carry the stone?" Pink Floyd