You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/07/06 18:56:19 UTC
[GitHub] [spark] amaliujia opened a new pull request, #37105: [SPARK-39700] Deprecate Catalog API that has input parameters (dbName, tableName/FunctionName)
amaliujia opened a new pull request, #37105:
URL: https://github.com/apache/spark/pull/37105
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Deprecate API that has parameters (DBName, tableName/FunctionName). Such API should use the version with single tableName/FunctionName parameter.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Given the 3l namespace support in Catalog API, now if a API takes, for example, `tableName`, it could be `a.b.c`. Such API can cover the case that user want to specify no only table name, but also db name and catalog name. Thus other API that takes (dbName, tableName) becomes both redundant (used to specify db name along with table name) and incomplete (cannot specify catalog name). We can deprecate such API to
1. reduce API surface while maintain the the power
2. reduce confusion and error pruning.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No. API are marked as deprecated but not deleted.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
N/A
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on pull request #37105: [SPARK-39700] Deprecate API that has parameters (DBName, tableName/FunctionName)
Posted by GitBox <gi...@apache.org>.
amaliujia commented on PR #37105:
URL: https://github.com/apache/spark/pull/37105#issuecomment-1176542815
R: @cloud-fan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #37105: [SPARK-39700][SQL] Deprecate Catalog API that has input parameters (dbName, tableName/FunctionName)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on PR #37105:
URL: https://github.com/apache/spark/pull/37105#issuecomment-1176983095
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HeartSaVioR commented on pull request #37105: [SPARK-39700][SQL] Deprecate Catalog API that has input parameters (dbName, tableName/FunctionName)
Posted by GitBox <gi...@apache.org>.
HeartSaVioR commented on PR #37105:
URL: https://github.com/apache/spark/pull/37105#issuecomment-1176958698
I sent out the discussion for deprecating trigger in dev@ mailing list. That said, what about initiating the discussion in dev@ mailing list so that there are reasonable objections on the topic?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #37105: [SPARK-39700][SQL] Deprecate Catalog API that has input parameters (dbName, tableName/FunctionName)
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on PR #37105:
URL: https://github.com/apache/spark/pull/37105#issuecomment-1184009973
Let's do a "soft deprecation": explain the limitation of the current API and suggest users to use alternatives in the API doc, but do not use the java deprecation annotation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a diff in pull request #37105: [SPARK-39700][SQL][DOCS] Update two-parameter `listColumns/getTable/getFunction/tableExists/functionExists` functions docs to mention limitation
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on code in PR #37105:
URL: https://github.com/apache/spark/pull/37105#discussion_r925206905
##########
sql/core/src/main/scala/org/apache/spark/sql/catalog/Catalog.scala:
##########
@@ -101,6 +101,9 @@ abstract class Catalog {
/**
* Returns a list of columns for the given table/view in the specified database.
*
+ * This API does not support 3 layer namespace since 3.4.0. To use 3 layer namespace,
Review Comment:
3 layer name is more common in traditional databases as the identifier is 3 parts: `catalog.schema.name`. But Spark is more general and the identifier has n parts: `catalog.ns1.ns2....name`.
I think `qualifiedNameWithCatalog` is more accurate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #37105: [SPARK-39700][SQL][DOCS] Update two-parameter `listColumns/getTable/getFunction/tableExists/functionExists` functions docs to mention limitation
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #37105: [SPARK-39700][SQL][DOCS] Update two-parameter `listColumns/getTable/getFunction/tableExists/functionExists` functions docs to mention limitation
URL: https://github.com/apache/spark/pull/37105
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #37105: [SPARK-39700][SQL] Deprecate Catalog API that has input parameters (dbName, tableName/FunctionName)
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on PR #37105:
URL: https://github.com/apache/spark/pull/37105#issuecomment-1176953116
@dongjoon-hyun we deprecated `createExternalTable` when we add `createTable`. I think it's good to keep the API clean and mark unneeded (and inconsistent) APIs as deprecated. The more important thing is: with deprecation, hopefully users will move away from these APIs slowly, and at some point, we can actually remove these APIs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on pull request #37105: [SPARK-39700][SQL] Deprecate Catalog API that has input parameters (dbName, tableName/FunctionName)
Posted by GitBox <gi...@apache.org>.
amaliujia commented on PR #37105:
URL: https://github.com/apache/spark/pull/37105#issuecomment-1176997585
I can drive a discussion in dev@ for this deprecation idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #37105: [SPARK-39700][SQL][DOCS] Update two-parameter `listColumns/getTable/getFunction/tableExists/functionExists` functions docs to mention limitation
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on code in PR #37105:
URL: https://github.com/apache/spark/pull/37105#discussion_r925165334
##########
sql/core/src/main/scala/org/apache/spark/sql/catalog/Catalog.scala:
##########
@@ -101,6 +101,9 @@ abstract class Catalog {
/**
* Returns a list of columns for the given table/view in the specified database.
*
+ * This API does not support 3 layer namespace since 3.4.0. To use 3 layer namespace,
Review Comment:
Just a question to @cloud-fan because I agree with you that that naming is confusing.
> 3 layer namespace is a bit confusing
I've monitored many commits in the community.
```
a2c1038031 [SPARK-39579][SQL][PYTHON][R] Make ListFunctions/getFunction/functionExists compatible with 3 layer namespace
6e7a571532 [SPARK-39649][PYTHON] Make listDatabases / getDatabase / listColumns / refreshTable in PySpark support 3-layer-namespace
cbb4e7da69 [SPARK-39646][SQL] Make setCurrentDatabase compatible with 3 layer namespace
b0d297c6d1 [SPARK-39645][SQL] Make getDatabase and listDatabases compatible with 3 layer namespace
8c02823b49 [SPARK-39583][SQL] Make RefreshTable be compatible with 3 layer namespace
ed1a3402d2 [SPARK-39598][PYTHON] Make *cache*, *catalog* in the python side support 3-layer-namespace
c1106fbe22 [SPARK-39597][PYTHON] Make GetTable, TableExists and DatabaseExists in the python side support 3-layer-namespace
1f15f2c6ad [SPARK-39615][SQL] Make listColumns be compatible with 3 layer namespace
b2d249b1aa [SPARK-39555][PYTHON] Make createTable and listTables in the python side support 3-layer-namespace
ca5f7e6c35 [SPARK-39263][SQL] Make GetTable, TableExists and DatabaseExists be compatible with 3 layer namespace
cb55efadea [SPARK-39236][SQL] Make CreateTable and ListTables be compatible with 3 layer namespace
```
Comments like this.
https://github.com/apache/spark/blob/0cc96f76d8a4858aee09e1fa32658da3ae76d384/python/pyspark/sql/catalog.py#L464
Even in function naming like this.
https://github.com/apache/spark/blob/0cc96f76d8a4858aee09e1fa32658da3ae76d384/sql/core/src/main/scala/org/apache/spark/sql/internal/CatalogImpl.scala#L424
I believe we need a naming rule for this to promote new naming or demote it by preventing further usage. Which way do you prefer, @cloud-fan ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #37105: [SPARK-39700][SQL] Deprecate Catalog API that has input parameters (dbName, tableName/FunctionName)
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #37105:
URL: https://github.com/apache/spark/pull/37105#issuecomment-1183975285
Did you talk with @cloud-fan ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #37105: [SPARK-39700][SQL][DOCS] Update two-parameter `listColumns/getTable/getFunction/tableExists/functionExists` functions docs to mention limitation
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on code in PR #37105:
URL: https://github.com/apache/spark/pull/37105#discussion_r925229444
##########
sql/core/src/main/scala/org/apache/spark/sql/catalog/Catalog.scala:
##########
@@ -101,6 +101,9 @@ abstract class Catalog {
/**
* Returns a list of columns for the given table/view in the specified database.
*
+ * This API does not support 3 layer namespace since 3.4.0. To use 3 layer namespace,
Review Comment:
Thank you so much, @cloud-fan !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a diff in pull request #37105: [SPARK-39700][SQL][DOCS] Update two-parameter `listColumns/getTable/getFunction/tableExists/functionExists` functions docs to mention limitation
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on code in PR #37105:
URL: https://github.com/apache/spark/pull/37105#discussion_r925126983
##########
sql/core/src/main/scala/org/apache/spark/sql/catalog/Catalog.scala:
##########
@@ -101,6 +101,9 @@ abstract class Catalog {
/**
* Returns a list of columns for the given table/view in the specified database.
*
+ * This API does not support 3 layer namespace since 3.4.0. To use 3 layer namespace,
Review Comment:
3 layer namespace is a bit confusing, how about
```
This API does not support specifying the catalog name. To specify the catalog name, please use
`listColumns(qualifiedTableNameWithCatalog)` instead.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on pull request #37105: [SPARK-39700][SQL] Deprecate Catalog API that has input parameters (dbName, tableName/FunctionName)
Posted by GitBox <gi...@apache.org>.
amaliujia commented on PR #37105:
URL: https://github.com/apache/spark/pull/37105#issuecomment-1189655466
@cloud-fan @dongjoon-hyun
I updated this PR to reflect our discussion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a diff in pull request #37105: [SPARK-39700][SQL][DOCS] Update two-parameter `listColumns/getTable/getFunction/tableExists/functionExists` functions docs to mention limitation
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on code in PR #37105:
URL: https://github.com/apache/spark/pull/37105#discussion_r925207319
##########
sql/core/src/main/scala/org/apache/spark/sql/catalog/Catalog.scala:
##########
@@ -101,6 +101,9 @@ abstract class Catalog {
/**
* Returns a list of columns for the given table/view in the specified database.
*
+ * This API does not support 3 layer namespace since 3.4.0. To use 3 layer namespace,
Review Comment:
let me clean the naming up in a followup PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #37105: [SPARK-39700][SQL][DOCS] Update two-parameter `listColumns/getTable/getFunction/tableExists/functionExists` functions docs to mention limitation
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on code in PR #37105:
URL: https://github.com/apache/spark/pull/37105#discussion_r929850532
##########
sql/core/src/main/scala/org/apache/spark/sql/catalog/Catalog.scala:
##########
@@ -101,6 +101,9 @@ abstract class Catalog {
/**
* Returns a list of columns for the given table/view in the specified database.
*
+ * This API does not support 3 layer namespace since 3.4.0. To use 3 layer namespace,
Review Comment:
Thank you, @cloud-fan .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #37105: [SPARK-39700][SQL] Deprecate Catalog API that has input parameters (dbName, tableName/FunctionName)
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #37105:
URL: https://github.com/apache/spark/pull/37105#issuecomment-1184891202
Thank you for the decision, @cloud-fan . I believe it makes sense in this case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on pull request #37105: [SPARK-39700][SQL] Deprecate Catalog API that has input parameters (dbName, tableName/FunctionName)
Posted by GitBox <gi...@apache.org>.
amaliujia commented on PR #37105:
URL: https://github.com/apache/spark/pull/37105#issuecomment-1184893023
Thanks all! I will update this API and the dev@ email thread to reflect the decision.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on pull request #37105: [SPARK-39700][SQL][DOCS] Update two-parameter `listColumns/getTable/getFunction/tableExists/functionExists` functions docs to mention limitation
Posted by GitBox <gi...@apache.org>.
amaliujia commented on PR #37105:
URL: https://github.com/apache/spark/pull/37105#issuecomment-1189691138
Thank you all for your review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a diff in pull request #37105: [SPARK-39700][SQL][DOCS] Update two-parameter `listColumns/getTable/getFunction/tableExists/functionExists` functions docs to mention limitation
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on code in PR #37105:
URL: https://github.com/apache/spark/pull/37105#discussion_r929604424
##########
sql/core/src/main/scala/org/apache/spark/sql/catalog/Catalog.scala:
##########
@@ -101,6 +101,9 @@ abstract class Catalog {
/**
* Returns a list of columns for the given table/view in the specified database.
*
+ * This API does not support 3 layer namespace since 3.4.0. To use 3 layer namespace,
Review Comment:
I'm working on it: https://github.com/apache/spark/pull/37287
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #37105: [SPARK-39700][SQL][DOCS] Update two-parameter `listColumns/getTable/getFunction/tableExists/functionExists` functions docs to mention limitation
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on code in PR #37105:
URL: https://github.com/apache/spark/pull/37105#discussion_r925165334
##########
sql/core/src/main/scala/org/apache/spark/sql/catalog/Catalog.scala:
##########
@@ -101,6 +101,9 @@ abstract class Catalog {
/**
* Returns a list of columns for the given table/view in the specified database.
*
+ * This API does not support 3 layer namespace since 3.4.0. To use 3 layer namespace,
Review Comment:
Just a question to @cloud-fan because I agree with you that that naming is confusing.
> 3 layer namespace is a bit confusing
I've monitored many commits in the community.
```
a2c1038031 [SPARK-39579][SQL][PYTHON][R] Make ListFunctions/getFunction/functionExists compatible with 3 layer namespace
6e7a571532 [SPARK-39649][PYTHON] Make listDatabases / getDatabase / listColumns / refreshTable in PySpark support 3-layer-namespace
cbb4e7da69 [SPARK-39646][SQL] Make setCurrentDatabase compatible with 3 layer namespace
b0d297c6d1 [SPARK-39645][SQL] Make getDatabase and listDatabases compatible with 3 layer namespace
8c02823b49 [SPARK-39583][SQL] Make RefreshTable be compatible with 3 layer namespace
ed1a3402d2 [SPARK-39598][PYTHON] Make *cache*, *catalog* in the python side support 3-layer-namespace
c1106fbe22 [SPARK-39597][PYTHON] Make GetTable, TableExists and DatabaseExists in the python side support 3-layer-namespace
1f15f2c6ad [SPARK-39615][SQL] Make listColumns be compatible with 3 layer namespace
b2d249b1aa [SPARK-39555][PYTHON] Make createTable and listTables in the python side support 3-layer-namespace
ca5f7e6c35 [SPARK-39263][SQL] Make GetTable, TableExists and DatabaseExists be compatible with 3 layer namespace
cb55efadea [SPARK-39236][SQL] Make CreateTable and ListTables be compatible with 3 layer namespace
```
Even in function naming like this.
https://github.com/apache/spark/blob/0cc96f76d8a4858aee09e1fa32658da3ae76d384/sql/core/src/main/scala/org/apache/spark/sql/internal/CatalogImpl.scala#L424
I believe we need a naming rule for this to promote new naming or demote it by preventing further usage. Which way do you prefer, @cloud-fan ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia closed pull request #37105: [SPARK-39700] Deprecate Catalog API that has input parameters (dbName, tableName/FunctionName)
Posted by GitBox <gi...@apache.org>.
amaliujia closed pull request #37105: [SPARK-39700] Deprecate Catalog API that has input parameters (dbName, tableName/FunctionName)
URL: https://github.com/apache/spark/pull/37105
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on pull request #37105: [SPARK-39700][SQL] Deprecate Catalog API that has input parameters (dbName, tableName/FunctionName)
Posted by GitBox <gi...@apache.org>.
amaliujia commented on PR #37105:
URL: https://github.com/apache/spark/pull/37105#issuecomment-1183974855
@dongjoon-hyun
Do you think we have reached a consensus that this will be an educational deprecation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #37105: [SPARK-39700][SQL] Deprecate Catalog API that has input parameters (dbName, tableName/FunctionName)
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #37105:
URL: https://github.com/apache/spark/pull/37105#issuecomment-1183977152
We shared opinions, but didn't make an agreement yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #37105: [SPARK-39700][SQL] Deprecate Catalog API that has input parameters (dbName, tableName/FunctionName)
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #37105:
URL: https://github.com/apache/spark/pull/37105#issuecomment-1184896693
Thank you for your patience and leading this discussion, @amaliujia .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on a diff in pull request #37105: [SPARK-39700][SQL][DOCS] Update two-parameter `listColumns/getTable/getFunction/tableExists/functionExists` functions docs to mention limitation
Posted by GitBox <gi...@apache.org>.
amaliujia commented on code in PR #37105:
URL: https://github.com/apache/spark/pull/37105#discussion_r925759765
##########
sql/core/src/main/scala/org/apache/spark/sql/catalog/Catalog.scala:
##########
@@ -101,6 +101,9 @@ abstract class Catalog {
/**
* Returns a list of columns for the given table/view in the specified database.
*
+ * This API does not support 3 layer namespace since 3.4.0. To use 3 layer namespace,
Review Comment:
Thank you for this discussion!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org