You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Jiangjie Qin (Jira)" <ji...@apache.org> on 2020/11/24 07:44:00 UTC

[jira] [Resolved] (FLINK-20194) KafkaSourceFetcherManager.commitOffsets() should handle the case when there is no split fetcher.

     [ https://issues.apache.org/jira/browse/FLINK-20194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jiangjie Qin resolved FLINK-20194.
----------------------------------
    Fix Version/s: 1.11.3
       Resolution: Fixed

merged to master
4bde1c9c10c0db2c44e25ea81ba04983b870b518.

The fix for SingleThreadFetcherManager has been cherry-picked back to 1.11.
78236cb12a78ef128a55ce14a0eb5eefb73cc735

> KafkaSourceFetcherManager.commitOffsets() should handle the case when there is no split fetcher.
> ------------------------------------------------------------------------------------------------
>
>                 Key: FLINK-20194
>                 URL: https://issues.apache.org/jira/browse/FLINK-20194
>             Project: Flink
>          Issue Type: Bug
>          Components: Connectors / Kafka
>            Reporter: Jiangjie Qin
>            Assignee: Jiangjie Qin
>            Priority: Blocker
>              Labels: pull-request-available
>             Fix For: 1.12.0, 1.11.3
>
>
> The {{KafkaSourceFetcherManager.commitOffsets()}} may throw NPE when there is no split fetcher. Given that such cases should usually be rare and only happens when the source is shutting down or just started. We can create a new {{KafkaPartitionSplitReader}} to commit offset and close it immediately. The main thread maybe blocked for some time, but given that there is no event to process at that point, there should be no performance concerns.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)