[GitHub] spark pull request #22279: [SPARK-25277][YARN] YARN applicationMaster metric...

[attilapiros <gi...@git.apache.org>]

Github user attilapiros commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22279#discussion_r225086020
  
    --- Diff: core/src/main/scala/org/apache/spark/metrics/MetricsSystem.scala ---
    @@ -103,6 +103,14 @@ private[spark] class MetricsSystem private (
         sinks.foreach(_.start)
       }
     
    +  // Same as start but this method only registers sinks
    --- End diff --
    
    I see it is a duplication of the start() method without the registerSources() but what about extending the start() method with a new boolean flag (like registerStaticSources:Boolean = true) and using this flag to decide registerSources() should be called or not. Then in AM you can call it with false.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org