[GitHub] [iceberg] jackye1995 commented on pull request #6660: Flink: Support writes to branches in FlinkSink

["jackye1995 (via GitHub)" <gi...@apache.org>]

jackye1995 commented on PR #6660:
URL: https://github.com/apache/iceberg/pull/6660#issuecomment-1404275883

   > As I implemented this though started to think we may just want to have a direct branch method on the FlinkSink builder itself. That seems more intuitive from an API perspective and is just easier to use.
   
   I think this is more of a question about convention, I will leave to people who use Flink more often to have an opinion. To me use `toBranch` definitely feels cleaner.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org