You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/08/27 21:18:44 UTC
[GitHub] [ozone] sodonnel opened a new pull request #2593: HDDS-5692. Combine some tests in TestOzoneManagerHAWithData to reuse mini-Clusters
sodonnel opened a new pull request #2593:
URL: https://github.com/apache/ozone/pull/2593
## What changes were proposed in this pull request?
Some tests in TestOzoneManagerHAWithData can naturally be combined. For example some run the same test with all OMs up and then one OM down.
Some other tests can be run on the same cluster in isolated buckets, as they do not restart any nodes.
This test suit typically runs for about 490 seconds , so it would be good to reduce its runtime.
```
[INFO] Running org.apache.hadoop.ozone.om.TestOzoneManagerHAWithData
Warning: Tests run: 12, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 490.975 s - in org.apache.hadoop.ozone.om.TestOzoneManagerHAWithData
```
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-5692
## How was this patch tested?
Existing tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] sodonnel merged pull request #2593: HDDS-5692. Combine some tests in TestOzoneManagerHAWithData to reuse mini-Clusters
Posted by GitBox <gi...@apache.org>.
sodonnel merged pull request #2593:
URL: https://github.com/apache/ozone/pull/2593
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] vivekratnavel commented on a change in pull request #2593: HDDS-5692. Combine some tests in TestOzoneManagerHAWithData to reuse mini-Clusters
Posted by GitBox <gi...@apache.org>.
vivekratnavel commented on a change in pull request #2593:
URL: https://github.com/apache/ozone/pull/2593#discussion_r697730521
##########
File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOzoneManagerHAWithData.java
##########
@@ -250,8 +249,7 @@ public void testFileOperationsWithNonRecursive() throws Exception {
}
- @Test
- public void testMultipartUploadWithOneOmNodeDown() throws Exception {
+ private void testMultipartUploadWithOneOmNodeDown() throws Exception {
OzoneBucket ozoneBucket = setupBucket();
Review comment:
Findbug reports a warning in Line 280 for the comparison operator used (!=)
Can we fix it to get a clean run?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] sodonnel commented on a change in pull request #2593: HDDS-5692. Combine some tests in TestOzoneManagerHAWithData to reuse mini-Clusters
Posted by GitBox <gi...@apache.org>.
sodonnel commented on a change in pull request #2593:
URL: https://github.com/apache/ozone/pull/2593#discussion_r697732520
##########
File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOzoneManagerHAWithData.java
##########
@@ -250,8 +249,7 @@ public void testFileOperationsWithNonRecursive() throws Exception {
}
- @Test
- public void testMultipartUploadWithOneOmNodeDown() throws Exception {
+ private void testMultipartUploadWithOneOmNodeDown() throws Exception {
OzoneBucket ozoneBucket = setupBucket();
Review comment:
Yea I just fixed it. Not sure why its warning about that, as I don't think I changed that code, but its an easy fix anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] vivekratnavel commented on a change in pull request #2593: HDDS-5692. Combine some tests in TestOzoneManagerHAWithData to reuse mini-Clusters
Posted by GitBox <gi...@apache.org>.
vivekratnavel commented on a change in pull request #2593:
URL: https://github.com/apache/ozone/pull/2593#discussion_r697740445
##########
File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOzoneManagerHAWithData.java
##########
@@ -250,8 +249,7 @@ public void testFileOperationsWithNonRecursive() throws Exception {
}
- @Test
- public void testMultipartUploadWithOneOmNodeDown() throws Exception {
+ private void testMultipartUploadWithOneOmNodeDown() throws Exception {
OzoneBucket ozoneBucket = setupBucket();
Review comment:
Thanks for fixing it @sodonnel. Sometimes, old bugs will show up when we touch the file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] sodonnel commented on pull request #2593: HDDS-5692. Combine some tests in TestOzoneManagerHAWithData to reuse mini-Clusters
Posted by GitBox <gi...@apache.org>.
sodonnel commented on pull request #2593:
URL: https://github.com/apache/ozone/pull/2593#issuecomment-907601971
The revised tests ran in:
```
[INFO] Running org.apache.hadoop.ozone.om.TestOzoneManagerHAWithData
Warning: Tests run: 8, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 332.16 s - in org.apache.hadoop.ozone.om.TestOzoneManagerHAWithData
```
Saving about 158 seconds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org