You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@griffin.apache.org by GitBox <gi...@apache.org> on 2019/09/26 02:39:16 UTC

[GitHub] [griffin] wankunde commented on issue #539: To support mariadb db as data source

wankunde commented on issue #539: To support mariadb db as data source
URL: https://github.com/apache/griffin/pull/539#issuecomment-535306197
 
 
   @guoyuepeng @MATRIX4284 
   LGTM
   
   If griffin have more and more dependency jars, maybe we should add some profiles ,so user can choose the datasources and sinks they needed...
   
   ```xml
       <profile>
         <id>Mysql</id>
         <dependencies>
           <dependency>
             <groupId>xxx</groupId>
             <artifactId>xxxx</artifactId>
             <version>$xxx</version>
           </dependency>
         </dependencies>
       </profile>
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services