You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2019/01/22 08:43:50 UTC
[GitHub] Klaster1 commented on a change in pull request #5869: IGNITE-10993
Web console cancel query
Klaster1 commented on a change in pull request #5869: IGNITE-10993 Web console cancel query
URL: https://github.com/apache/ignite/pull/5869#discussion_r249665388
##########
File path: modules/web-console/frontend/app/components/page-queries/components/queries-notebook/controller.ts
##########
@@ -1323,12 +1368,37 @@ export class NotebookCtrl {
const _closeOldQuery = (paragraph) => {
const nid = paragraph.resNodeId;
- if (paragraph.queryId && _.find($scope.caches, ({nodes}) => _.find(nodes, {nid: nid.toUpperCase()})))
- return agentMgr.queryClose(nid, paragraph.queryId);
+ if (paragraph.queryId) {
+ const qryId = paragraph.queryId;
+ delete paragraph.queryId;
+
+ return agentMgr.queryClose(nid, qryId);
+ }
return $q.when();
};
+ $scope.cancelQuery = (paragraph) => {
+ if (paragraph.subscription) {
Review comment:
See above about explicit subscription management.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services