You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "no1wudi (via GitHub)" <gi...@apache.org> on 2026/03/23 12:50:16 UTC
[PR] style: Fix "is is" typo across the codebase. [nuttx]
no1wudi opened a new pull request, #18585:
URL: https://github.com/apache/nuttx/pull/18585
## Summary
Fix "is is" typo (duplicate "is") across the codebase. This is a pure style/documentation fix that corrects duplicate word typos found in 181 files.
In most cases "is is" was changed to "is", but in contexts like "MCU is is sleep mode" it was corrected to "MCU in sleep mode".
Also fixes a "the the" typo in net/inet/inet_sockif.c.
## Impact
- Impact on user: NO
- Impact on build: NO
- Impact on hardware: NO
- Impact on documentation: YES - Documentation comments are corrected
- Impact on security: NO
- Impact on compatibility: NO
## Testing
No functional testing required - this is a documentation/style-only change that fixes typos in comments and documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] style: Fix "is is" typo across the codebase. [nuttx]
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on PR #18585:
URL: https://github.com/apache/nuttx/pull/18585#issuecomment-4110747530
@no1wudi search for " is is " instead of "is is"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] style: Fix "is is" typo across the codebase. [nuttx]
Posted by "no1wudi (via GitHub)" <gi...@apache.org>.
no1wudi commented on PR #18585:
URL: https://github.com/apache/nuttx/pull/18585#issuecomment-4110923408
> Thank you for this effort! Most fixes are correct; however I found a few incorrect ones (see individual comments). Thanks!
@hartmannathan @acassis Nice catch!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] style: Fix "is is" typo across the codebase. [nuttx]
Posted by "hartmannathan (via GitHub)" <gi...@apache.org>.
hartmannathan commented on code in PR #18585:
URL: https://github.com/apache/nuttx/pull/18585#discussion_r2975060056
##########
arch/risc-v/src/mpfs/mpfs_ihc.c:
##########
@@ -973,7 +973,7 @@ static bool mpfs_rptun_is_master(struct rptun_dev_s *dev)
* Name: mpfs_rptun_start
*
* Description:
- * Rptun start notifier. This is unused at the moment.
Review Comment:
This 'is' was correct. It should not be removed.
##########
arch/risc-v/src/mpfs/mpfs_i2c.c:
##########
@@ -427,7 +427,7 @@ static int mpfs_i2c_init(struct mpfs_i2c_priv_s *priv)
priv->frequency = mpfs_i2c_freqs[0];
}
- /* This is our own address, not the target chip */
Review Comment:
This 'is' was correct; it should not be removed.
##########
crypto/curve25519.c:
##########
@@ -1096,7 +1096,7 @@ int curve25519(uint8_t out[CURVE25519_KEY_SIZE],
* 2456d821825521f7e03e65882cc3521795b0320f/ \
* src/Spec/MontgomeryCurve.v#L27>
*
- * Proof that these form a group that is isomorphic to a Weierstrass
+ * Proof that these form a group that it isomorphic to a Weierstrass
Review Comment:
The'is' was correct here; please don't change 'is' to 'it's here.
##########
drivers/mtd/filemtd.c:
##########
@@ -632,7 +632,7 @@ static int mtd_loop_teardown(FAR const char *devname)
dev = (FAR struct file_dev_s *)inode->u.i_mtd;
- /* Validate this is a filemtd backended device */
+ /* Validate this it a filemtd backended device */
Review Comment:
The 'is' was correct here; please don't change to 'it's.
##########
arch/xtensa/src/esp32/esp32_himem.h:
##########
@@ -38,7 +38,7 @@ extern "C"
* Pre-processor Definitions
****************************************************************************/
-/* Indicates that a mapping will only be read from. Note that this is unused
Review Comment:
Ditto: This 'is' was correct; it should not be removed.
##########
drivers/wireless/ieee802154/xbee/xbee_netdev.c:
##########
@@ -97,7 +97,7 @@
* Private Types
****************************************************************************/
-/* This is our private version of the MAC callback structure */
Review Comment:
The 'is' is correct here, please don't remove.
##########
wireless/ieee802154/mac802154_netdev.c:
##########
@@ -109,7 +109,7 @@
* Private Types
****************************************************************************/
-/* This is our private version of the MAC callback structure */
Review Comment:
Ditto; the 'is' is correct here, please don't remove.
##########
audio/pcm_decode.c:
##########
@@ -51,7 +51,7 @@
struct pcm_decode_s
{
- /* This is is our our appearance to the outside world. This *MUST* be the
+ /* This our appearance to the outside world. This *MUST* be the
Review Comment:
We should keep one 'is' here.
##########
wireless/bluetooth/bt_netdev.c:
##########
@@ -81,7 +81,7 @@
* Private Types
****************************************************************************/
-/* This is our private version of the MAC callback structure */
Review Comment:
The 'is' is correct here, please don't remove.
##########
fs/nxffs/nxffs_inode.c:
##########
@@ -465,7 +465,7 @@ off_t nxffs_inodeend(FAR struct nxffs_volume_s *volume,
off_t minblocks = (entry->datlen + maxsize - 1) / maxsize;
- /* And this is our best, simple guess at the end of the inode data */
Review Comment:
Ditto: the 'is' is correct here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] style: Fix "is is" typo across the codebase. [nuttx]
Posted by "hartmannathan (via GitHub)" <gi...@apache.org>.
hartmannathan commented on code in PR #18585:
URL: https://github.com/apache/nuttx/pull/18585#discussion_r2975096318
##########
crypto/curve25519.c:
##########
@@ -1096,7 +1096,7 @@ int curve25519(uint8_t out[CURVE25519_KEY_SIZE],
* 2456d821825521f7e03e65882cc3521795b0320f/ \
* src/Spec/MontgomeryCurve.v#L27>
*
- * Proof that these form a group that is isomorphic to a Weierstrass
+ * Proof that these form a group that it isomorphic to a Weierstrass
Review Comment:
The 'is' was correct here; please don't change 'is' to 'it' here.
##########
drivers/mtd/filemtd.c:
##########
@@ -632,7 +632,7 @@ static int mtd_loop_teardown(FAR const char *devname)
dev = (FAR struct file_dev_s *)inode->u.i_mtd;
- /* Validate this is a filemtd backended device */
+ /* Validate this it a filemtd backended device */
Review Comment:
The 'is' was correct here; please don't change to 'it'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] style: Fix "is is" typo across the codebase. [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #18585:
URL: https://github.com/apache/nuttx/pull/18585
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org