You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Jinmei Liao <ji...@pivotal.io> on 2016/05/19 21:55:56 UTC
Review Request 47617: GEODE-17: add regionName in some of the commands
authorization
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47617/
-----------------------------------------------------------
Review request for geode.
Repository: geode
Description
-------
GEODE-17: add regionName in some of the commands authorization
* added region check in query commands
* added region check in alter region
* added region check in define index/create index
Diffs
-----
geode-core/src/main/java/com/gemstone/gemfire/internal/security/GeodeSecurityUtil.java 322c59e1f1a42818efa5a58cab6e3268774d60eb
geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/CreateAlterDestroyRegionCommands.java 06c096fbbb3fdc75c3d7feaa2f41186cdcfd4174
geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/DataCommands.java fafea9a4843bddaef2df4c7d8404cead37b64c1c
geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/IndexCommands.java 24f9f7173de6a8947fac00a14168ec0b51c95182
geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/functions/DataCommandFunction.java b4e73406c534744b8f7f92c3a598b88e9a18c885
geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/TestCommand.java 667330ce0dcba0fc571d8466559a700b7c4f587e
Diff: https://reviews.apache.org/r/47617/diff/
Testing
-------
precheckin running
Thanks,
Jinmei Liao
Re: Review Request 47617: GEODE-17: add regionName in some of the
commands authorization
Posted by Jinmei Liao <ji...@pivotal.io>.
> On May 20, 2016, 1:52 p.m., Jens Deppe wrote:
> > geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/IndexCommands.java, line 377
> > <https://reviews.apache.org/r/47617/diff/2/?file=1388633#file1388633line377>
> >
> > Authorization should probably occur at this point too.
> >
> > There must be a way to determine on which region an index is defined; we should look at retrieving that info and doing an explicit 'authorizeRegionManage' check here.
check in for now. Will create another story to deal with destroy index.
- Jinmei
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47617/#review134141
-----------------------------------------------------------
On May 20, 2016, 1:19 a.m., Jinmei Liao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47617/
> -----------------------------------------------------------
>
> (Updated May 20, 2016, 1:19 a.m.)
>
>
> Review request for geode.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-17: add regionName in some of the commands authorization
>
> * added region check in query commands
> * added region check in alter region
> * added region check in define index/create index
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/internal/security/GeodeSecurityUtil.java 322c59e1f1a42818efa5a58cab6e3268774d60eb
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/CreateAlterDestroyRegionCommands.java 06c096fbbb3fdc75c3d7feaa2f41186cdcfd4174
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/DataCommands.java fafea9a4843bddaef2df4c7d8404cead37b64c1c
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/IndexCommands.java 24f9f7173de6a8947fac00a14168ec0b51c95182
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/functions/DataCommandFunction.java b4e73406c534744b8f7f92c3a598b88e9a18c885
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/web/controllers/support/MemberMXBeanAdapter.java a3d4cd02921ead659a8b44201f5d11be4820abe6
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/CliCommandsSecurityTest.java 0864e5226eff853bdcb03e305b489ddd1e5a207e
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/GfshCommandsSecurityTest.java b21302e4477097459136dddd4316bffc733234d6
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/TestCommand.java 667330ce0dcba0fc571d8466559a700b7c4f587e
> geode-core/src/test/resources/com/gemstone/gemfire/management/internal/security/cacheServer.json 638ae07802ddf4967513803eb98b394486361f6c
>
> Diff: https://reviews.apache.org/r/47617/diff/
>
>
> Testing
> -------
>
> precheckin running
>
>
> Thanks,
>
> Jinmei Liao
>
>
Re: Review Request 47617: GEODE-17: add regionName in some of the
commands authorization
Posted by Jens Deppe <jd...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47617/#review134141
-----------------------------------------------------------
geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/IndexCommands.java (line 364)
<https://reviews.apache.org/r/47617/#comment198802>
Authorization should probably occur at this point too.
There must be a way to determine on which region an index is defined; we should look at retrieving that info and doing an explicit 'authorizeRegionManage' check here.
- Jens Deppe
On May 20, 2016, 1:19 a.m., Jinmei Liao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47617/
> -----------------------------------------------------------
>
> (Updated May 20, 2016, 1:19 a.m.)
>
>
> Review request for geode.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-17: add regionName in some of the commands authorization
>
> * added region check in query commands
> * added region check in alter region
> * added region check in define index/create index
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/internal/security/GeodeSecurityUtil.java 322c59e1f1a42818efa5a58cab6e3268774d60eb
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/CreateAlterDestroyRegionCommands.java 06c096fbbb3fdc75c3d7feaa2f41186cdcfd4174
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/DataCommands.java fafea9a4843bddaef2df4c7d8404cead37b64c1c
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/IndexCommands.java 24f9f7173de6a8947fac00a14168ec0b51c95182
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/functions/DataCommandFunction.java b4e73406c534744b8f7f92c3a598b88e9a18c885
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/web/controllers/support/MemberMXBeanAdapter.java a3d4cd02921ead659a8b44201f5d11be4820abe6
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/CliCommandsSecurityTest.java 0864e5226eff853bdcb03e305b489ddd1e5a207e
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/GfshCommandsSecurityTest.java b21302e4477097459136dddd4316bffc733234d6
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/TestCommand.java 667330ce0dcba0fc571d8466559a700b7c4f587e
> geode-core/src/test/resources/com/gemstone/gemfire/management/internal/security/cacheServer.json 638ae07802ddf4967513803eb98b394486361f6c
>
> Diff: https://reviews.apache.org/r/47617/diff/
>
>
> Testing
> -------
>
> precheckin running
>
>
> Thanks,
>
> Jinmei Liao
>
>
Re: Review Request 47617: GEODE-17: add regionName in some of the
commands authorization
Posted by Jinmei Liao <ji...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47617/
-----------------------------------------------------------
(Updated May 20, 2016, 1:19 a.m.)
Review request for geode.
Repository: geode
Description
-------
GEODE-17: add regionName in some of the commands authorization
* added region check in query commands
* added region check in alter region
* added region check in define index/create index
Diffs (updated)
-----
geode-core/src/main/java/com/gemstone/gemfire/internal/security/GeodeSecurityUtil.java 322c59e1f1a42818efa5a58cab6e3268774d60eb
geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/CreateAlterDestroyRegionCommands.java 06c096fbbb3fdc75c3d7feaa2f41186cdcfd4174
geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/DataCommands.java fafea9a4843bddaef2df4c7d8404cead37b64c1c
geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/IndexCommands.java 24f9f7173de6a8947fac00a14168ec0b51c95182
geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/functions/DataCommandFunction.java b4e73406c534744b8f7f92c3a598b88e9a18c885
geode-core/src/main/java/com/gemstone/gemfire/management/internal/web/controllers/support/MemberMXBeanAdapter.java a3d4cd02921ead659a8b44201f5d11be4820abe6
geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/CliCommandsSecurityTest.java 0864e5226eff853bdcb03e305b489ddd1e5a207e
geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/GfshCommandsSecurityTest.java b21302e4477097459136dddd4316bffc733234d6
geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/TestCommand.java 667330ce0dcba0fc571d8466559a700b7c4f587e
geode-core/src/test/resources/com/gemstone/gemfire/management/internal/security/cacheServer.json 638ae07802ddf4967513803eb98b394486361f6c
Diff: https://reviews.apache.org/r/47617/diff/
Testing
-------
precheckin running
Thanks,
Jinmei Liao