You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@yunikorn.apache.org by "aplufr (via GitHub)" <gi...@apache.org> on 2023/02/10 13:18:36 UTC
[GitHub] [yunikorn-release] aplufr opened a new pull request, #128: Fix linespace control on ingress
aplufr opened a new pull request, #128:
URL: https://github.com/apache/yunikorn-release/pull/128
blank line are required otherwise rendering will not produce a valide yaml file for k8s.
Symptoms: "Error: unable to build kubernetes objects from release manifest: error validating "": error validating data: apiVersion not set"
Reason: apiVersion is not set on it's own line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org
[GitHub] [yunikorn-release] craigcondit closed pull request #128: [YUNIKORN-1577] Fix linespace control on ingress
Posted by "craigcondit (via GitHub)" <gi...@apache.org>.
craigcondit closed pull request #128: [YUNIKORN-1577] Fix linespace control on ingress
URL: https://github.com/apache/yunikorn-release/pull/128
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org
[GitHub] [yunikorn-release] wilfred-s commented on pull request #128: Fix linespace control on ingress
Posted by "wilfred-s (via GitHub)" <gi...@apache.org>.
wilfred-s commented on PR #128:
URL: https://github.com/apache/yunikorn-release/pull/128#issuecomment-1427149862
Created jira account, jira and assigned it to @aplufr.
https://issues.apache.org/jira/browse/YUNIKORN-1577
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org
[GitHub] [yunikorn-release] aplufr commented on pull request #128: Fix linespace control on ingress
Posted by "aplufr (via GitHub)" <gi...@apache.org>.
aplufr commented on PR #128:
URL: https://github.com/apache/yunikorn-release/pull/128#issuecomment-1426045063
> Hi @aplufr, please open a JIRA at https://issues.apache.org/jira/projects/YUNIKORN/issues first. We track all changes through JIRA.
I don't have a JIRA account yet but I've send an email to address mentioned on https://yunikorn.apache.org/community/how_to_contribute ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org
[GitHub] [yunikorn-release] craigcondit commented on pull request #128: Fix linespace control on ingress
Posted by "craigcondit (via GitHub)" <gi...@apache.org>.
craigcondit commented on PR #128:
URL: https://github.com/apache/yunikorn-release/pull/128#issuecomment-1426063229
> I don't have a JIRA account yet but I've send an email to address mentioned on https://yunikorn.apache.org/community/how_to_contribute ;)
I haven't seen it come through yet, but that list is manually moderated for non-members. You can also create an account on the YuniKorn slack channel and DM me there with the info.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org
[GitHub] [yunikorn-release] aplufr commented on a diff in pull request #128: Fix linespace control on ingress
Posted by "aplufr (via GitHub)" <gi...@apache.org>.
aplufr commented on code in PR #128:
URL: https://github.com/apache/yunikorn-release/pull/128#discussion_r1102973658
##########
helm-charts/yunikorn/templates/ingress.yaml:
##########
@@ -14,7 +14,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-{{- if .Values.ingress.enabled -}}
+{{ if .Values.ingress.enabled }}
Review Comment:
Others yaml from the helm do not have any dash on first conditional. But indeed removing only the trailing dash is enough to fix ingress deployment and avoid extra line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org
[GitHub] [yunikorn-release] craigcondit commented on a diff in pull request #128: Fix linespace control on ingress
Posted by "craigcondit (via GitHub)" <gi...@apache.org>.
craigcondit commented on code in PR #128:
URL: https://github.com/apache/yunikorn-release/pull/128#discussion_r1102950591
##########
helm-charts/yunikorn/templates/ingress.yaml:
##########
@@ -14,7 +14,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-{{- if .Values.ingress.enabled -}}
+{{ if .Values.ingress.enabled }}
Review Comment:
Please leave the leading dash to match the same pattern as others (otherwise an extra line is generated). Only the trailing dash should be removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org
[GitHub] [yunikorn-release] craigcondit commented on a diff in pull request #128: Fix linespace control on ingress
Posted by "craigcondit (via GitHub)" <gi...@apache.org>.
craigcondit commented on code in PR #128:
URL: https://github.com/apache/yunikorn-release/pull/128#discussion_r1102950035
##########
helm-charts/yunikorn/templates/ingress.yaml:
##########
@@ -57,4 +57,4 @@ spec:
number: {{ .Values.service.portWeb }}
{{- end }}
{{- end }}
-{{- end }}
Review Comment:
This line should not be changed.
##########
helm-charts/yunikorn/templates/ingress.yaml:
##########
@@ -14,7 +14,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-{{- if .Values.ingress.enabled -}}
+{{ if .Values.ingress.enabled }}
Review Comment:
Please leave the leading dash to match the same pattern as others (otherwise an extra line is generated). Only the trailing slash should be removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org
[GitHub] [yunikorn-release] craigcondit commented on pull request #128: Fix linespace control on ingress
Posted by "craigcondit (via GitHub)" <gi...@apache.org>.
craigcondit commented on PR #128:
URL: https://github.com/apache/yunikorn-release/pull/128#issuecomment-1426027248
Hi @aplufr, please open a JIRA at https://issues.apache.org/jira/projects/YUNIKORN/issues first. We track all changes through JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org