You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Di Li <di...@ca.ibm.com> on 2017/12/22 14:48:22 UTC
Review Request 64809: AMBARI-22685 Stack OS/repos removed from cluster
installation UI showed up on the Versions tab after cluster is installed
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64809/
-----------------------------------------------------------
Review request for Ambari and Tim Thorpe.
Bugs: AMBARI-22685
https://issues.apache.org/jira/browse/AMBARI-22685
Repository: ambari
Description
-------
Even when a user had remove say Diebian , SLES OS/repos from cluster installation UI after selecting a stack, they still showed up on the Versions tab after cluster was installed.
Diffs
-----
ambari-web/app/controllers/installer.js f49fc11
ambari-web/app/controllers/wizard/step8_controller.js e64a09a
Diff: https://reviews.apache.org/r/64809/diff/1/
Testing
-------
existing unit tests, patch a trunk cluster with the changes, remove some of the OS from the stack page during cluster installation, run thru cluster install. From Ambari web UI, on the Versions tab, check os/repos shown on the cluster, verify only the ones selected during the installation time remain.
Thanks,
Di Li
Re: Review Request 64809: AMBARI-22685 Stack OS/repos removed from
cluster
installation UI showed up on the Versions tab after cluster is installed
Posted by Tim Thorpe <tt...@ca.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64809/#review194447
-----------------------------------------------------------
Ship it!
Ship It!
- Tim Thorpe
On Dec. 22, 2017, 2:48 p.m., Di Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64809/
> -----------------------------------------------------------
>
> (Updated Dec. 22, 2017, 2:48 p.m.)
>
>
> Review request for Ambari and Tim Thorpe.
>
>
> Bugs: AMBARI-22685
> https://issues.apache.org/jira/browse/AMBARI-22685
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Even when a user had remove say Diebian , SLES OS/repos from cluster installation UI after selecting a stack, they still showed up on the Versions tab after cluster was installed.
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/installer.js f49fc11
> ambari-web/app/controllers/wizard/step8_controller.js e64a09a
>
>
> Diff: https://reviews.apache.org/r/64809/diff/1/
>
>
> Testing
> -------
>
> existing unit tests, patch a trunk cluster with the changes, remove some of the OS from the stack page during cluster installation, run thru cluster install. From Ambari web UI, on the Versions tab, check os/repos shown on the cluster, verify only the ones selected during the installation time remain.
>
>
> Thanks,
>
> Di Li
>
>