[GitHub] [skywalking] wu-sheng commented on a change in pull request #5949: Support Kafka MirrorMaker 2.0 to replicate topics between Kafka clusters.

[GitBox <gi...@apache.org>]

wu-sheng commented on a change in pull request #5949:
URL: https://github.com/apache/skywalking/pull/5949#discussion_r535876183



##########
File path: oap-server/server-fetcher-plugin/kafka-fetcher-plugin/src/main/java/org/apache/skywalking/oap/server/analyzer/agent/kafka/module/KafkaFetcherConfig.java
##########
@@ -84,5 +84,29 @@
     private int kafkaHandlerThreadPoolSize;
 
     private int kafkaHandlerThreadPoolQueueSize;
-
+    
+    private String MM2SourceAlias = "";
+
+    private String MM2SourceSeparator = "";

Review comment:
       I can't find the place using these, have you submitted all codes?

##########
File path: docs/en/setup/backend/backend-fetcher.md
##########
@@ -122,3 +122,22 @@ kafka-fetcher:
       enable.auto.commit: true
       ...
 ```
+
+When useing Kafka MirrorMaker 2.0 to replicate topics between Kafka clusters, you can set the source Kafka Cluster alias(MM2SourceAlias) and separator(MM2SourceSeparator) according to your Kafka MirrorMaker config:

Review comment:
       ```suggestion
   When use Kafka MirrorMaker 2.0 to replicate topics between Kafka clusters, you can set the source Kafka Cluster alias(MM2SourceAlias) and separator(MM2SourceSeparator) according to your Kafka MirrorMaker config.
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org