You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by da...@apache.org on 2020/03/15 11:21:26 UTC
[camel] 02/03: CAMEL-14575: camel-core - TypeConverter from String
to Long - drop time pattern
This is an automated email from the ASF dual-hosted git repository.
davsclaus pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/camel.git
commit 30724eba8e1fde3112512347ede54cae681b680c
Author: Claus Ibsen <cl...@gmail.com>
AuthorDate: Sun Mar 15 11:08:44 2020 +0100
CAMEL-14575: camel-core - TypeConverter from String to Long - drop time pattern
---
.../services/org/apache/camel/TypeConverterLoader | 1 -
.../modules/ROOT/pages/camel-3x-upgrade-guide.adoc | 26 ++++++++++++++++++++++
2 files changed, 26 insertions(+), 1 deletion(-)
diff --git a/core/camel-base/src/generated/resources/META-INF/services/org/apache/camel/TypeConverterLoader b/core/camel-base/src/generated/resources/META-INF/services/org/apache/camel/TypeConverterLoader
index b0702fe..a16a584 100644
--- a/core/camel-base/src/generated/resources/META-INF/services/org/apache/camel/TypeConverterLoader
+++ b/core/camel-base/src/generated/resources/META-INF/services/org/apache/camel/TypeConverterLoader
@@ -7,5 +7,4 @@ org.apache.camel.converter.IOConverterLoader
org.apache.camel.converter.NIOConverterLoader
org.apache.camel.converter.ObjectConverterLoader
org.apache.camel.converter.SQLConverterLoader
-org.apache.camel.converter.TimePatternConverterLoader
org.apache.camel.impl.converter.UriTypeConverterLoader
diff --git a/docs/user-manual/modules/ROOT/pages/camel-3x-upgrade-guide.adoc b/docs/user-manual/modules/ROOT/pages/camel-3x-upgrade-guide.adoc
index 8e44115..1298f61 100644
--- a/docs/user-manual/modules/ROOT/pages/camel-3x-upgrade-guide.adoc
+++ b/docs/user-manual/modules/ROOT/pages/camel-3x-upgrade-guide.adoc
@@ -771,6 +771,32 @@ from("direct:error").loadBalance().roundRobin().id("round")
The base support for cluster in `org.apache.camel.cluster` has been moved
out of `camel-core-engine` into separate JAR named `camel-cluster`.
+=== Configuring milli seconds
+
+Camel was using a type converter from `String` -> `long` that accepted
+a time pattern which allowed to configure long values such as `2s` for 2 seconds, eg `2000`.
+And more complex such as `8h15m` for 8 hours and 15 minutes.
+
+However as this was implemented as part of `String` -> `long` type convertion
+which then adds a little bit of overhead during routing, when converting from String to plain numbers.
+
+To make Camel routing engine as fast as possible, then this has been removed.
+
+For example a timer with a 5 second period
+
+[source,java]
+----
+from("timer:foo?period=5s")
+----
+
+Should now be specified as numeric only:
+
+[source,java]
+----
+from("timer:foo?period=5000")
+----
+
+
=== API changes
==== DefaultComponent