You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "leonardBang (via GitHub)" <gi...@apache.org> on 2026/06/17 15:50:55 UTC
[PR] [test] Try to Fix flaky tests with AI assistance [flink-cdc]
leonardBang opened a new pull request, #4444:
URL: https://github.com/apache/flink-cdc/pull/4444
Try to Fix flaky tests with AI assistance
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [test] Try to Fix flaky tests with AI assistance [flink-cdc]
Posted by "yuxiqian (via GitHub)" <gi...@apache.org>.
yuxiqian commented on code in PR #4444:
URL: https://github.com/apache/flink-cdc/pull/4444#discussion_r3524860807
##########
flink-cdc-e2e-tests/flink-cdc-pipeline-e2e-tests/src/test/java/org/apache/flink/cdc/pipeline/tests/MysqlToKafkaE2eITCase.java:
##########
@@ -347,6 +352,28 @@ public void testSyncWholeDatabaseWithDebeziumJsonHasSchema() throws Exception {
.containsExactlyInAnyOrderElementsOf(deserializeValues(collectedRecords));
}
+ private void waitUntilStreamSplitReady(JobID jobId, int parallelism) throws Exception {
Review Comment:
Could be moved to `PipelineTestEnvironment` base class?
##########
.github/workflows/flink_cdc_base.yml:
##########
@@ -99,15 +99,15 @@ jobs:
modules=$(./.github/workflows/modules.py test "${{ matrix.module }}")
compile_modules=$(./.github/workflows/modules.py compile "${{ matrix.module }}")
-
+
build_maven_parameter="-DspecifiedMongoVersion=8.0.14"
if [ ! -z "${{ matrix.flink-version }}" ]; then
build_maven_parameter="${build_maven_parameter:+$build_maven_parameter }-DspecifiedFlinkVersion=${{ matrix.flink-version }}"
fi
-
+
build_maven_parameter="${build_maven_parameter:+$build_maven_parameter }${{ inputs.custom-maven-parameter }}"
-
+
Review Comment:
Accidental changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [test] Try to Fix flaky tests with AI assistance [flink-cdc]
Posted by "yuxiqian (via GitHub)" <gi...@apache.org>.
yuxiqian commented on code in PR #4444:
URL: https://github.com/apache/flink-cdc/pull/4444#discussion_r3449773133
##########
flink-cdc-connect/flink-cdc-source-connectors/flink-connector-sqlserver-cdc/src/test/java/org/apache/flink/cdc/connectors/sqlserver/table/SqlServerConnectorITCase.java:
##########
@@ -358,6 +360,18 @@ void testStartupFromTimestampWithServerTimeZone() throws Exception {
@ParameterizedTest
@ValueSource(booleans = {true, false})
void testAllTypes(boolean parallelismSnapshot) throws Throwable {
+ // CI runs tests under a randomized -Duser.timezone (see .github/workflows/utils.sh). On
+ // sub-hour offsets (e.g. GMT+11:30) Debezium 1.9.8 underflows NanoOfSecond while converting
+ // the streamed TIME columns of full_types, which drops the +U record and stalls the sink
+ // until the job-level timeout. The JVM default cannot be re-pinned here because the
+ // SQL Server JDBC driver resolves the zone outside this thread's TimeZone.getDefault(), so
+ // skip this type-coverage case on sub-hour offsets; timezone behaviour is covered by
+ // SqlServerTimezoneITCase.
+ Assumptions.assumeThat(
+ TimeZone.getDefault().getRawOffset() % (int) TimeUnit.HOURS.toMillis(1))
+ .as(
+ "Skipping on sub-hour timezone offset due to Debezium TIME conversion limitation")
+ .isZero();
Review Comment:
It's suspicious to skip the entire test case. Shall we consider modifying the `.github/workflows/utils.sh` and always generate time zones on the hour?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [test] Try to Fix flaky tests with AI assistance [flink-cdc]
Posted by "yuxiqian (via GitHub)" <gi...@apache.org>.
yuxiqian commented on code in PR #4444:
URL: https://github.com/apache/flink-cdc/pull/4444#discussion_r3475589544
##########
flink-cdc-e2e-tests/flink-cdc-pipeline-e2e-tests/src/test/java/org/apache/flink/cdc/pipeline/tests/OracleE2eITCase.java:
##########
@@ -224,56 +205,84 @@ void testSyncWholeDatabase() throws Exception {
"DataChangeEvent{tableId=DEBEZIUM.PRODUCTS, before=[106, hammer, 16oz carpenters hammer, 1.0], after=[106, hammer, 18oz carpenter hammer, 1.0], op=UPDATE, meta=()}");
waitUntilSpecificEvent(
"DataChangeEvent{tableId=DEBEZIUM.PRODUCTS, before=[107, rocks, box of assorted rocks, 5.3], after=[107, rocks, box of assorted rocks, 5.1], op=UPDATE, meta=()}");
- waitUntilSpecificEvent(
- "CreateTableEvent{tableId=DEBEZIUM.CUSTOMERS_1, schema=columns={`ID` BIGINT NOT NULL,`NAME` VARCHAR(255) NOT NULL,`ADDRESS` VARCHAR(1024),`PHONE_NUMBER` VARCHAR(512)}, primaryKeys=ID, options=()}");
Review Comment:
The original test case looks suspicious. Why `DEBEZIUM.CUSTOMERS`'s primary key `ID INT NOT NULL` maps to a BIGINT and its value has changed from digits (ranges from 100 to 2000) to 171,798,691,841 or `0x2800000001`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [test] Try to Fix flaky tests with AI assistance [flink-cdc]
Posted by "leonardBang (via GitHub)" <gi...@apache.org>.
leonardBang commented on code in PR #4444:
URL: https://github.com/apache/flink-cdc/pull/4444#discussion_r3482557200
##########
flink-cdc-e2e-tests/flink-cdc-pipeline-e2e-tests/src/test/java/org/apache/flink/cdc/pipeline/tests/OracleE2eITCase.java:
##########
@@ -224,56 +205,84 @@ void testSyncWholeDatabase() throws Exception {
"DataChangeEvent{tableId=DEBEZIUM.PRODUCTS, before=[106, hammer, 16oz carpenters hammer, 1.0], after=[106, hammer, 18oz carpenter hammer, 1.0], op=UPDATE, meta=()}");
waitUntilSpecificEvent(
"DataChangeEvent{tableId=DEBEZIUM.PRODUCTS, before=[107, rocks, box of assorted rocks, 5.3], after=[107, rocks, box of assorted rocks, 5.1], op=UPDATE, meta=()}");
- waitUntilSpecificEvent(
- "CreateTableEvent{tableId=DEBEZIUM.CUSTOMERS_1, schema=columns={`ID` BIGINT NOT NULL,`NAME` VARCHAR(255) NOT NULL,`ADDRESS` VARCHAR(1024),`PHONE_NUMBER` VARCHAR(512)}, primaryKeys=ID, options=()}");
Review Comment:
You are right. The `171798691841/842` values are not valid fixture IDs and should not be accepted as an alternative rendering of the customer primary key. That would make the assertion too loose and could hide a real data correctness issue.
I updated the test to assert the actual fixture IDs for the current pipeline e2e path, which uses the Oracle incremental snapshot source. The assertion now only keeps the `BIGINT` / `DECIMAL(38, 0)` schema alternative, because that is a schema type-rendering difference for Oracle `INT` / `NUMBER`, not a data value difference. If we need to cover legacy source behavior separately, we should add a source-specific assertion/test for that path instead of accepting different ID values in this incremental snapshot test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [test][build] Try to fix flaky tests with AI assistance [flink-cdc]
Posted by "leonardBang (via GitHub)" <gi...@apache.org>.
leonardBang commented on PR #4444:
URL: https://github.com/apache/flink-cdc/pull/4444#issuecomment-4889055217
CI passed and the stability is better than before, merging...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [test] Try to Fix flaky tests with AI assistance [flink-cdc]
Posted by "leonardBang (via GitHub)" <gi...@apache.org>.
leonardBang commented on code in PR #4444:
URL: https://github.com/apache/flink-cdc/pull/4444#discussion_r3459565997
##########
flink-cdc-connect/flink-cdc-source-connectors/flink-connector-sqlserver-cdc/src/test/java/org/apache/flink/cdc/connectors/sqlserver/table/SqlServerConnectorITCase.java:
##########
@@ -358,6 +360,18 @@ void testStartupFromTimestampWithServerTimeZone() throws Exception {
@ParameterizedTest
@ValueSource(booleans = {true, false})
void testAllTypes(boolean parallelismSnapshot) throws Throwable {
+ // CI runs tests under a randomized -Duser.timezone (see .github/workflows/utils.sh). On
+ // sub-hour offsets (e.g. GMT+11:30) Debezium 1.9.8 underflows NanoOfSecond while converting
+ // the streamed TIME columns of full_types, which drops the +U record and stalls the sink
+ // until the job-level timeout. The JVM default cannot be re-pinned here because the
+ // SQL Server JDBC driver resolves the zone outside this thread's TimeZone.getDefault(), so
+ // skip this type-coverage case on sub-hour offsets; timezone behaviour is covered by
+ // SqlServerTimezoneITCase.
+ Assumptions.assumeThat(
+ TimeZone.getDefault().getRawOffset() % (int) TimeUnit.HOURS.toMillis(1))
+ .as(
+ "Skipping on sub-hour timezone offset due to Debezium TIME conversion limitation")
+ .isZero();
Review Comment:
Nice catch, will address your comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [test] Try to Fix flaky tests with AI assistance [flink-cdc]
Posted by "leonardBang (via GitHub)" <gi...@apache.org>.
leonardBang commented on PR #4444:
URL: https://github.com/apache/flink-cdc/pull/4444#issuecomment-4800798112
latest CI passed again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [test] Try to Fix flaky tests with AI assistance [flink-cdc]
Posted by "yuxiqian (via GitHub)" <gi...@apache.org>.
yuxiqian commented on code in PR #4444:
URL: https://github.com/apache/flink-cdc/pull/4444#discussion_r3475539283
##########
flink-cdc-e2e-tests/flink-cdc-pipeline-e2e-tests/src/test/java/org/apache/flink/cdc/pipeline/tests/OracleE2eITCase.java:
##########
@@ -170,50 +171,30 @@ void testSyncWholeDatabase() throws Exception {
waitUntilSpecificEvent(
"DataChangeEvent{tableId=DEBEZIUM.PRODUCTS, before=[], after=[105, hammer, 14oz carpenters hammer, 0.875], op=INSERT, meta=()}");
- waitUntilSpecificEvent(
- "CreateTableEvent{tableId=DEBEZIUM.CUSTOMERS, schema=columns={`ID` BIGINT NOT NULL,`NAME` VARCHAR(255) NOT NULL,`ADDRESS` VARCHAR(1024),`PHONE_NUMBER` VARCHAR(512)}, primaryKeys=ID, options=()}");
- waitUntilSpecificEvent(
- "DataChangeEvent{tableId=DEBEZIUM.CUSTOMERS, before=[], after=[171798691841, user_1, Shanghai, 123567891234], op=INSERT, meta=()}");
- waitUntilSpecificEvent(
- "DataChangeEvent{tableId=DEBEZIUM.CUSTOMERS, before=[], after=[171798691841, user_4, Shanghai, 123567891234], op=INSERT, meta=()}");
- waitUntilSpecificEvent(
- "DataChangeEvent{tableId=DEBEZIUM.CUSTOMERS, before=[], after=[171798691841, user_3, Shanghai, 123567891234], op=INSERT, meta=()}");
- waitUntilSpecificEvent(
- "DataChangeEvent{tableId=DEBEZIUM.CUSTOMERS, before=[], after=[171798691841, user_2, Shanghai, 123567891234], op=INSERT, meta=()}");
- waitUntilSpecificEvent(
- "DataChangeEvent{tableId=DEBEZIUM.CUSTOMERS, before=[], after=[171798691842, user_13, Shanghai, 123567891234], op=INSERT, meta=()}");
- waitUntilSpecificEvent(
- "DataChangeEvent{tableId=DEBEZIUM.CUSTOMERS, before=[], after=[171798691842, user_14, Shanghai, 123567891234], op=INSERT, meta=()}");
- waitUntilSpecificEvent(
- "DataChangeEvent{tableId=DEBEZIUM.CUSTOMERS, before=[], after=[171798691842, user_11, Shanghai, 123567891234], op=INSERT, meta=()}");
- waitUntilSpecificEvent(
- "DataChangeEvent{tableId=DEBEZIUM.CUSTOMERS, before=[], after=[171798691842, user_12, Shanghai, 123567891234], op=INSERT, meta=()}");
- waitUntilSpecificEvent(
- "DataChangeEvent{tableId=DEBEZIUM.CUSTOMERS, before=[], after=[171798691842, user_21, Shanghai, 123567891234], op=INSERT, meta=()}");
- waitUntilSpecificEvent(
- "DataChangeEvent{tableId=DEBEZIUM.CUSTOMERS, before=[], after=[171798691842, user_10, Shanghai, 123567891234], op=INSERT, meta=()}");
- waitUntilSpecificEvent(
- "DataChangeEvent{tableId=DEBEZIUM.CUSTOMERS, before=[], after=[171798691841, user_6, Shanghai, 123567891234], op=INSERT, meta=()}");
- waitUntilSpecificEvent(
- "DataChangeEvent{tableId=DEBEZIUM.CUSTOMERS, before=[], after=[171798691841, user_5, Shanghai, 123567891234], op=INSERT, meta=()}");
- waitUntilSpecificEvent(
- "DataChangeEvent{tableId=DEBEZIUM.CUSTOMERS, before=[], after=[171798691841, user_9, Shanghai, 123567891234], op=INSERT, meta=()}");
- waitUntilSpecificEvent(
- "DataChangeEvent{tableId=DEBEZIUM.CUSTOMERS, before=[], after=[171798691842, user_19, Shanghai, 123567891234], op=INSERT, meta=()}");
- waitUntilSpecificEvent(
- "DataChangeEvent{tableId=DEBEZIUM.CUSTOMERS, before=[], after=[171798691842, user_20, Shanghai, 123567891234], op=INSERT, meta=()}");
- waitUntilSpecificEvent(
- "DataChangeEvent{tableId=DEBEZIUM.CUSTOMERS, before=[], after=[171798691841, user_8, Shanghai, 123567891234], op=INSERT, meta=()}");
- waitUntilSpecificEvent(
- "DataChangeEvent{tableId=DEBEZIUM.CUSTOMERS, before=[], after=[171798691842, user_17, Shanghai, 123567891234], op=INSERT, meta=()}");
- waitUntilSpecificEvent(
- "DataChangeEvent{tableId=DEBEZIUM.CUSTOMERS, before=[], after=[171798691842, user_18, Shanghai, 123567891234], op=INSERT, meta=()}");
- waitUntilSpecificEvent(
- "DataChangeEvent{tableId=DEBEZIUM.CUSTOMERS, before=[], after=[171798691842, user_15, Shanghai, 123567891234], op=INSERT, meta=()}");
- waitUntilSpecificEvent(
- "DataChangeEvent{tableId=DEBEZIUM.CUSTOMERS, before=[], after=[171798691841, user_7, Shanghai, 123567891234], op=INSERT, meta=()}");
- waitUntilSpecificEvent(
- "DataChangeEvent{tableId=DEBEZIUM.CUSTOMERS, before=[], after=[171798691842, user_16, Shanghai, 123567891234], op=INSERT, meta=()}");
+ waitUntilAnySpecificEvent(
+ "CreateTableEvent{tableId=DEBEZIUM.CUSTOMERS, schema=columns={`ID` BIGINT NOT NULL,`NAME` VARCHAR(255) NOT NULL,`ADDRESS` VARCHAR(1024),`PHONE_NUMBER` VARCHAR(512)}, primaryKeys=ID, options=()}",
+ "CreateTableEvent{tableId=DEBEZIUM.CUSTOMERS, schema=columns={`ID` DECIMAL(38, 0) NOT NULL,`NAME` VARCHAR(255) NOT NULL,`ADDRESS` VARCHAR(1024),`PHONE_NUMBER` VARCHAR(512)}, primaryKeys=ID, options=()}");
+ waitUntilCustomerInsert("DEBEZIUM.CUSTOMERS", 101, "user_1");
Review Comment:
Write these assertions in order?
##########
flink-cdc-e2e-tests/flink-cdc-pipeline-e2e-tests/src/test/java/org/apache/flink/cdc/pipeline/tests/TransformE2eITCase.java:
##########
@@ -339,6 +344,7 @@ void testAssortedSchemaTransform(boolean batchMode) throws Exception {
void testWildcardSchemaTransform(boolean batchMode) throws Exception {
String startupMode = batchMode ? "snapshot" : "initial";
String runtimeMode = batchMode ? "BATCH" : "STREAMING";
+ int testParallelism = 1;
Review Comment:
Why this case doesn't work in multiple parallelism mode?
##########
flink-cdc-e2e-tests/flink-cdc-pipeline-e2e-tests/src/test/java/org/apache/flink/cdc/pipeline/tests/OracleE2eITCase.java:
##########
@@ -224,56 +205,84 @@ void testSyncWholeDatabase() throws Exception {
"DataChangeEvent{tableId=DEBEZIUM.PRODUCTS, before=[106, hammer, 16oz carpenters hammer, 1.0], after=[106, hammer, 18oz carpenter hammer, 1.0], op=UPDATE, meta=()}");
waitUntilSpecificEvent(
"DataChangeEvent{tableId=DEBEZIUM.PRODUCTS, before=[107, rocks, box of assorted rocks, 5.3], after=[107, rocks, box of assorted rocks, 5.1], op=UPDATE, meta=()}");
- waitUntilSpecificEvent(
- "CreateTableEvent{tableId=DEBEZIUM.CUSTOMERS_1, schema=columns={`ID` BIGINT NOT NULL,`NAME` VARCHAR(255) NOT NULL,`ADDRESS` VARCHAR(1024),`PHONE_NUMBER` VARCHAR(512)}, primaryKeys=ID, options=()}");
Review Comment:
The original test case looks suspicious. Why `DEBEZIUM.CUSTOMERS`'s primary key `ID INT NOT NULL` maps to a BIGINT and its value has changed?
##########
flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mongodb-cdc/src/test/java/org/apache/flink/cdc/connectors/mongodb/source/NewlyAddedTableITCase.java:
##########
@@ -503,8 +508,11 @@ private void testRemoveAndAddCollectionsOneByOne(
// assert fetched changelog data in this round
MongoDBTestUtils.waitForSinkSize("sink", fetchedDataList.size());
- MongoDBAssertUtils.assertEqualsInAnyOrder(
- fetchedDataList, TestValuesTableFactory.getRawResultsAsStrings("sink"));
+ assertEqualsInAnyOrderWithAllowedDuplicateUpdatePair(
+ fetchedDataList,
+ TestValuesTableFactory.getRawResultsAsStrings("sink"),
+ collection0UpdateBefore,
+ collection0UpdateAfter);
Review Comment:
This assertion is really cryptic. IIUC it is basically asserting this:
```java
assertThat(TestValuesTableFactory.getRawResultsAsStrings("sink"))
.satisfiesAnyOf(
actual -> assertThat(actual)
.containsExactlyInAnyOrderElementsOf(expected),
actual -> assertThat(actual)
.containsExactlyInAnyOrderElementsOf(expectedWithRetryDuplicate));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [test] Try to Fix flaky tests with AI assistance [flink-cdc]
Posted by "leonardBang (via GitHub)" <gi...@apache.org>.
leonardBang commented on PR #4444:
URL: https://github.com/apache/flink-cdc/pull/4444#issuecomment-4795736948
Stable enough for now, will organize commits and push later, would you like to take a look? @yuxiqian @lvyanquan
<img width="1242" height="870" alt="image" src="https://github.com/user-attachments/assets/0892e0ee-5862-4f35-815e-5148560f6a4b" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [test] Try to Fix flaky tests with AI assistance [flink-cdc]
Posted by "leonardBang (via GitHub)" <gi...@apache.org>.
leonardBang commented on code in PR #4444:
URL: https://github.com/apache/flink-cdc/pull/4444#discussion_r3481718042
##########
flink-cdc-e2e-tests/flink-cdc-pipeline-e2e-tests/src/test/java/org/apache/flink/cdc/pipeline/tests/TransformE2eITCase.java:
##########
@@ -339,6 +344,7 @@ void testAssortedSchemaTransform(boolean batchMode) throws Exception {
void testWildcardSchemaTransform(boolean batchMode) throws Exception {
String startupMode = batchMode ? "snapshot" : "initial";
String runtimeMode = batchMode ? "BATCH" : "STREAMING";
+ int testParallelism = 1;
Review Comment:
will add parameterized test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [test][build] Try to fix flaky tests with AI assistance [flink-cdc]
Posted by "leonardBang (via GitHub)" <gi...@apache.org>.
leonardBang merged PR #4444:
URL: https://github.com/apache/flink-cdc/pull/4444
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [test] Try to Fix flaky tests with AI assistance [flink-cdc]
Posted by "leonardBang (via GitHub)" <gi...@apache.org>.
leonardBang commented on code in PR #4444:
URL: https://github.com/apache/flink-cdc/pull/4444#discussion_r3507643526
##########
flink-cdc-e2e-tests/flink-cdc-pipeline-e2e-tests/src/test/java/org/apache/flink/cdc/pipeline/tests/OracleE2eITCase.java:
##########
@@ -224,56 +205,84 @@ void testSyncWholeDatabase() throws Exception {
"DataChangeEvent{tableId=DEBEZIUM.PRODUCTS, before=[106, hammer, 16oz carpenters hammer, 1.0], after=[106, hammer, 18oz carpenter hammer, 1.0], op=UPDATE, meta=()}");
waitUntilSpecificEvent(
"DataChangeEvent{tableId=DEBEZIUM.PRODUCTS, before=[107, rocks, box of assorted rocks, 5.3], after=[107, rocks, box of assorted rocks, 5.1], op=UPDATE, meta=()}");
- waitUntilSpecificEvent(
- "CreateTableEvent{tableId=DEBEZIUM.CUSTOMERS_1, schema=columns={`ID` BIGINT NOT NULL,`NAME` VARCHAR(255) NOT NULL,`ADDRESS` VARCHAR(1024),`PHONE_NUMBER` VARCHAR(512)}, primaryKeys=ID, options=()}");
Review Comment:
nice catch, rebase current PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [test] Try to Fix flaky tests with AI assistance [flink-cdc]
Posted by "yuxiqian (via GitHub)" <gi...@apache.org>.
yuxiqian commented on code in PR #4444:
URL: https://github.com/apache/flink-cdc/pull/4444#discussion_r3506678044
##########
flink-cdc-e2e-tests/flink-cdc-pipeline-e2e-tests/src/test/java/org/apache/flink/cdc/pipeline/tests/OracleE2eITCase.java:
##########
@@ -224,56 +205,84 @@ void testSyncWholeDatabase() throws Exception {
"DataChangeEvent{tableId=DEBEZIUM.PRODUCTS, before=[106, hammer, 16oz carpenters hammer, 1.0], after=[106, hammer, 18oz carpenter hammer, 1.0], op=UPDATE, meta=()}");
waitUntilSpecificEvent(
"DataChangeEvent{tableId=DEBEZIUM.PRODUCTS, before=[107, rocks, box of assorted rocks, 5.3], after=[107, rocks, box of assorted rocks, 5.1], op=UPDATE, meta=()}");
- waitUntilSpecificEvent(
- "CreateTableEvent{tableId=DEBEZIUM.CUSTOMERS_1, schema=columns={`ID` BIGINT NOT NULL,`NAME` VARCHAR(255) NOT NULL,`ADDRESS` VARCHAR(1024),`PHONE_NUMBER` VARCHAR(512)}, primaryKeys=ID, options=()}");
Review Comment:
I believe it's a legit bug instead of some "alternative rendering" and should have been resolved in #4424. Better revert changes in this test case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org