You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by nmwael <gi...@git.apache.org> on 2016/04/29 11:45:20 UTC
[GitHub] wicket pull request: now importing the correct cglib, so that wick...
GitHub user nmwael opened a pull request:
https://github.com/apache/wicket/pull/169
now importing the correct cglib, so that wicket will play along with …
…pax-wicket
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nmwael/wicket wicket-6.x
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/wicket/pull/169.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #169
----
commit 7db070ed412ae3f24798b1f9c4909f46ea6eeb2a
Author: nmw <nm...@netdesign.dk>
Date: 2016-04-29T09:43:34Z
now importing the correct cglib, so that wicket will play along with pax-wicket
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket pull request: now importing the correct cglib, so that wick...
Posted by martin-g <gi...@git.apache.org>.
Github user martin-g commented on the pull request:
https://github.com/apache/wicket/pull/169#issuecomment-215676316
wicket-core doesn't use CGLIB!
wicket-ioc does use CGLIB.
I'm afraid your PR is invalid.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket pull request: now importing the correct cglib, so that wick...
Posted by nmwael <gi...@git.apache.org>.
Github user nmwael commented on the pull request:
https://github.com/apache/wicket/pull/169#issuecomment-215738028
seems the dynamic cglib import are comming from pax wicket.. SO I will fix it there, where it should be fixed!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket pull request: now importing the correct cglib, so that wick...
Posted by nmwael <gi...@git.apache.org>.
Github user nmwael closed the pull request at:
https://github.com/apache/wicket/pull/169
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---